-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supporting taints via NFD operator #239
Comments
This would be very nice feature, making tainting a lot more user-friendly. |
We will start working on it once we finish with the refactoring |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
Taints are specified in the NodeRules objects, and are applied by master pod. This may cause the NFD worker pods on the tainted nodes to become unscheduled, since NFD operator is not aware of the NodeRules and is not updating the worker daemonsets with appropriate tolerations.
The possible solution is to create additional controller in the operator, that will watch for NodeRules creation. In case NodeRule contains taint definition, the controller will kick off reconcilation of the nodefeaturediscovery controller, which will check the presence of the taints in any existing NodeRule and will update the worker daemonset accordingly.
The new controller will have to watch for Create and Update events, but not for Delete events, since there is no problem for worker to be running with additional tolerations
Reconciliation kick-off can be achieved by applying an annotation to the NFD CR. We can agree on a specific naming , and the value of the annotation will be increased subsequently with each time the reconciliation loop needs to be restarted
The text was updated successfully, but these errors were encountered: