Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: parallelize nodes update #1096

Closed
AhmedGrati opened this issue Mar 23, 2023 · 3 comments · Fixed by #1133
Closed

Enhancement: parallelize nodes update #1096

AhmedGrati opened this issue Mar 23, 2023 · 3 comments · Fixed by #1133
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@AhmedGrati
Copy link

What would you like to be added:
Currently, we are updating nodes in a sequential way.

// TODO: we might want to update multiple nodes in parallel
if updateAll {
if err := m.nfdAPIUpdateAllNodes(); err != nil {
klog.Error(err)
}
} else {
for nodeName := range updateNodes {
if err := m.nfdAPIUpdateOneNode(nodeName); err != nil {
klog.Error(err)
}
}
}

I think that we can optimize this step by parallelizing this process.

Why is this needed:
Optimization of updating nodes process, in terms of execution time.

@AhmedGrati AhmedGrati added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 23, 2023
@AhmedGrati
Copy link
Author

AhmedGrati commented Mar 23, 2023

If relevant, I can work on it.

@marquiz
Copy link
Contributor

marquiz commented Apr 1, 2023

Thanks @AhmedGrati for the proposal. I think this would be a good improvement 👍 Just need to figure out a reasonable default for the parallelism

@AhmedGrati
Copy link
Author

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants