Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common library functions klog config file option handling #1339

Closed
marquiz opened this issue Sep 7, 2023 · 1 comment · Fixed by #1341
Closed

Common library functions klog config file option handling #1339

marquiz opened this issue Sep 7, 2023 · 1 comment · Fixed by #1341
Assignees
@AhmedGrati
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@marquiz
Copy link
Contributor

marquiz commented Sep 7, 2023

What would you like to be added:

From #1338 (review): nfd-master and nfd-worker have virtually identical functionality for handling the klog options (cmdline and config file). It would make sense to try to refactor these into one common library.

Why is this needed:

Remove code duplication, less LOC, easier maintenance.
@marquiz marquiz added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 7, 2023
@marquiz
Copy link
Contributor Author

marquiz commented Sep 7, 2023

/assign @AhmedGrati

@AhmedGrati AhmedGrati mentioned this issue Sep 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AhmedGrati AhmedGrati

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: introduce a commong klog handling for cmd/nfd-* AhmedGrati/node-feature-discovery
2 participants
@marquiz @AhmedGrati