Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete useless options in controller #567

Closed
nayihz opened this issue Mar 30, 2023 · 0 comments · Fixed by #569
Closed

Delete useless options in controller #567

nayihz opened this issue Mar 30, 2023 · 0 comments · Fixed by #569
Assignees

Comments

@nayihz
Copy link
Contributor

nayihz commented Mar 30, 2023

./bin/controller -h
Usage of ./bin/controller:
      --burst int              burst of query apiserver. (default 10)
      --enableLeaderElection   If EnableLeaderElection for controller.
      --incluster              If controller run incluster.
      --kubeConfig string      Kube Config path if not run in cluster.
      --kubeconfig string      Paths to a kubeconfig. Only required if out-of-cluster.
      --masterUrl string       Master Url if not run in cluster.
      --metricsAddr string     Metrics server bind listen address. (default ":8080")
      --probeAddr string       Probe endpoint bind  address. (default ":8081")
      --qps int                qps of query apiserver. (default 5)
      --workers int            workers of scheduler-plugin-controllers. (default 1)

There are some options which should be discarded after we migrate controller to ctrl runtime, such as enableLeaderElection/kubeConfig/ incluster.
Meanwhile we should also discard options which were never been used, such as workers.

/assign

@nayihz nayihz changed the title delete useless option in controller Delete useless options in controller Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant