Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code generation incorrect since 1.29 bump #729

Closed
4 tasks
SebMuir-Smith opened this issue May 6, 2024 · 1 comment · Fixed by #747
Closed
4 tasks

Code generation incorrect since 1.29 bump #729

SebMuir-Smith opened this issue May 6, 2024 · 1 comment · Fixed by #747
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@SebMuir-Smith
Copy link

SebMuir-Smith commented May 6, 2024

Area

  • Scheduler
  • Controller
  • Helm Chart
  • Documents

Other components

Code Generation

What happened?

Commit 99de67d moved from generate-groups.sh/generate-internal-groups.sh to kube_codegen.sh for code generation. The former was a callable script, and the latter simply defines functions that should be called separately.

This transition doesn't seem to have been done correctly; kube_codegen.sh is being called as if it was an executable script, which does absolutely nothing.

The codegen now looks to be broken and seemingly will not generate anything when it is run.

What did you expect to happen?

Migration should have been done according to the new usage of kube_codegen.sh, i.e. https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/code-generator/examples/hack/update-codegen.sh

How can we reproduce it (as minimally and precisely as possible)?

  1. Delete files that were previously generated by generate-groups.sh/generate-internal-groups.sh.
  2. Run ./hack/update-codegen.sh
  3. Observe that files were not replaced

Anything else we need to know?

No response

Kubernetes version

N/A

Scheduler Plugins version

N/A

@Huang-Wei
Copy link
Contributor

Huang-Wei commented May 22, 2024

Thanks for the report. I created a revert PR #747 to fix this issue.

#748 is created to track the codegen script's migration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants