Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm chart separate out toleration for daemonset and crd upgrade hook #1535

Open
sstarcher opened this issue May 29, 2024 · 2 comments · May be fixed by #1538
Open

helm chart separate out toleration for daemonset and crd upgrade hook #1535

sstarcher opened this issue May 29, 2024 · 2 comments · May be fixed by #1538
Assignees
@omerap12
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@sstarcher
Copy link

Describe the solution you'd like
Currently the CRD upgrade hook and the daemonset share the toleration configuration. We have a toleration of Exists specified which allows our daemonsets to continue to run on cordoned nodes, but this causes the CRD upgrade hook to potentially hang.
@sstarcher sstarcher added the kind/feature Categorizes issue or PR as related to a new feature. label May 29, 2024
@omerap12
Copy link

omerap12 commented Jun 1, 2024

I believe I can help with that :)

@omerap12
Copy link

omerap12 commented Jun 1, 2024

/assign

@omerap12 omerap12 linked a pull request Jun 5, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@omerap12 omerap12

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

separate toleration daemonset and crd upgrade hook omerap12/secrets-store-csi-driver
2 participants
@sstarcher @omerap12