Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CA: Put APIs in a separate go module #6307

Closed
tenzen-y opened this issue Nov 21, 2023 · 4 comments · Fixed by #6315
Closed

CA: Put APIs in a separate go module #6307

tenzen-y opened this issue Nov 21, 2023 · 4 comments · Fixed by #6315
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@tenzen-y
Copy link
Member

Which component are you using?:

ClusterAutoscaler

Is your feature request designed to solve a problem? If so describe the problem this feature should solve.:

If the external project imports cluster-autoscaler, the external project can't run go list -modfile=./go.mod -m all
because the cluster-autoscaler depends on k/k repository.

By these limitations, Goland (JetBrains) wouldn't work fine.
Please see the details: kubernetes-sigs/kueue#1345

Describe the solution you'd like.:

As we discussed in the above issue with @x13n and @alculquicondor, the best solution is to put APIs in a separate go module.

Describe any alternative solutions you've considered.:

Additional context.:

@tenzen-y tenzen-y added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 21, 2023
@tenzen-y
Copy link
Member Author

/assign

@tenzen-y
Copy link
Member Author

Probably, it would be better to put the client in a separate module as well.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 22, 2024
@tenzen-y
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants