Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

building cluster-autoscaler with clusterapi build tag fails #6489

Closed
elmiko opened this issue Jan 31, 2024 · 2 comments · Fixed by #6491
Closed

building cluster-autoscaler with clusterapi build tag fails #6489

elmiko opened this issue Jan 31, 2024 · 2 comments · Fixed by #6491
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@elmiko
Copy link
Contributor

elmiko commented Jan 31, 2024

Which component are you using?:

cluster-autoscaler

What version of the component are you using?:

Component version: master

What k8s version are you using (kubectl version)?:

n/a

What environment is this in?:

this is during the build process, not while running, i ran the following:

$ go build --tags clusterapi -o ./cluster-autoscaler-amd64 

What did you expect to happen?:

expect that the cluster autoscaler binary is built

What happened instead?:

i get an error

# k8s.io/autoscaler/cluster-autoscaler/cloudprovider/builder
cloudprovider/builder/cloud_provider_builder.go:46:47: too many arguments in call to buildCloudProvider
        have ("k8s.io/autoscaler/cluster-autoscaler/config".AutoscalingOptions, "k8s.io/autoscaler/cluster-autoscaler/cloudprovider".NodeGroupDiscoveryOptions, *"k8s.io/autoscaler/cluster-autoscaler/cloudprovider".ResourceLimiter, informers.SharedInformerFactory)
        want ("k8s.io/autoscaler/cluster-autoscaler/config".AutoscalingOptions, "k8s.io/autoscaler/cluster-autoscaler/cloudprovider".NodeGroupDiscoveryOptions, *"k8s.io/autoscaler/cluster-autoscaler/cloudprovider".ResourceLimiter)

How to reproduce it (as minimally and precisely as possible):

  1. check out code
  2. cd cluster-autoscaler
  3. go build --tags clusterapi -o ./cluster-autoscaler-amd64

Anything else we need to know?:

the fix is relatively simple, update the buildCloudProvider function in the cloudprovider/builder/builder_clusterapi.go file

@elmiko elmiko added the kind/bug Categorizes issue or PR as related to a bug. label Jan 31, 2024
@elmiko
Copy link
Contributor Author

elmiko commented Jan 31, 2024

/assign

@Shubham82
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants