Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vpa: Follow Kubernetes logging guideline #6905

Open
ialidzhikov opened this issue Jun 7, 2024 · 3 comments
Open

vpa: Follow Kubernetes logging guideline #6905

ialidzhikov opened this issue Jun 7, 2024 · 3 comments
Labels
area/vertical-pod-autoscaler kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@ialidzhikov
Copy link
Contributor

ialidzhikov commented Jun 7, 2024

Which component are you using?:

vertical-pod-autoscaler

Is your feature request designed to solve a problem? If so describe the problem this feature should solve.:

Currently, the logging in the VPA components does not follow the best practices and guidelines which are followed in the K8s ecosystem. VPA, as a core K8s component, should follow sig-instrumentation's Logging guide.

For example, let's take

klog.V(2).Infof("evicting pod %v", pod.Name)
. The issues with this log are:

Describe the solution you'd like.:
Follow sig-instrumentation's Logging guide in the VPA's codebase.

Describe any alternative solutions you've considered.:
N/A

Additional context.:
N/A

@ialidzhikov ialidzhikov added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 7, 2024
@Shubham82
Copy link
Contributor

/area vertical-pod-autoscaler

@Shubham82
Copy link
Contributor

cc @voelzmo @kwiesmueller

@voelzmo
Copy link
Contributor

voelzmo commented Jul 15, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vertical-pod-autoscaler kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

4 participants