-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include similar nodegroups in gRPC expander options #6941
base: master
Are you sure you want to change the base?
include similar nodegroups in gRPC expander options #6941
Conversation
The committers listed above are authorized under a signed CLA. |
Welcome @BenHinthorne! |
Hi @BenHinthorne. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BenHinthorne The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Related to #6940
This PR updates the gRPC expanders Options request to include SimilarNodegroupIds. The purpose of adding this option is two fold:
An example use case for why users may want to filter the similar nodegroups in the gRPC expander is to filter nodegroups by a maximum number of nodes per zone, to prevent scaling in zones that experience IP Exhaustion (see issue). Another example would be that this allows users to prevent upscaling in zones in which they may have an outage, via filtering out these options via their gRPC expander.
It's also worth noting that the the other built-in expanders have SimilarNodegroups included by default, because the
expander.Option
type includes similar nodegroups, it was only the *protos.Option type which did not.Which issue(s) this PR fixes:
Fixes #6940
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: