Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert resources to a more human relevant SI #7417

Closed
jacobeatsspam opened this issue Oct 21, 2024 · 4 comments · Fixed by #7428
Closed

Convert resources to a more human relevant SI #7417

jacobeatsspam opened this issue Oct 21, 2024 · 4 comments · Fixed by #7428
Assignees
Labels
area/vertical-pod-autoscaler kind/feature Categorizes issue or PR as related to a new feature.

Comments

@jacobeatsspam
Copy link

Which component are you using?:

VPA

Is your feature request designed to solve a problem? If so describe the problem this feature should solve.:

Yes. VPA memory recommendations are applied as kilobytes (k, the non-binary 1000 byte) and it's not very relevant to the humans that are reading the podspec later.

Describe the solution you'd like.:

Convert to the units to highest SI suffix without decimal places.

Describe any alternative solutions you've considered.:

N/A

@jacobeatsspam jacobeatsspam added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 21, 2024
@adrianmoisey
Copy link
Member

/area vertical-pod-autoscaler

This looks like a dupe of #7094

@omerap12
Copy link
Member

I’m happy to help with that if needed.

@adrianmoisey
Copy link
Member

Go for it!
/assign omerap12

@kyleli666
Copy link

kyleli666 commented Jan 26, 2025

Hi all, I tried with 1.3.0 image with "--humanize-memory=true" today, but found the MEM value now having more digits with the unit "milibyte". This value looks to align with the code design 272063528960/1000/1024/1024=259.46Mi, but seems more unreadable. Is there some configuration I missed?

$ k get verticalpodautoscalers.autoscaling.k8s.io -n logging fluent-bit-service
NAME                 MODE      CPU    MEM             PROVIDED   AGE
fluent-bit-service   Initial   126m   272063528960m   True       2d21h

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vertical-pod-autoscaler kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants