Add ProvisioningRequestProcessor #6488

yaroslava-serdiuk · 2024-01-31T10:32:09Z

What type of PR is this?

/kind feature

ProvisioningRequestProcessor reconciles ProvisioningRequest state/conditions. It checks whether BookingExpired condition should be added or ProvisioningRequest was pending too long.
Also removed CapacityFound condition and use uniform Provisioned condition instead.

What this PR does / why we need it:

Part of implementation https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/proposals/provisioning-request.md

cluster-autoscaler/provisioningrequest/checkcapacity/processor.go

cluster-autoscaler/processors/processors.go

kisieland

/lgtm

cluster-autoscaler/provisioningrequest/checkcapacity/processor.go

k8s-ci-robot · 2024-02-07T13:33:53Z

@kisieland: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cluster-autoscaler/provisioningrequest/checkcapacity/processor.go

cluster-autoscaler/core/static_autoscaler.go

x13n

Thanks, mostly LGTM. I don't particularly like the two-level processor, but I think with a bit of renaming and shuffling the code around, it would be slightly cleaner. Specifically, I suggest:

Renaming ProvisioningRequestProcessor provreq.ProvisioningRequestProcessor to LoopStartNotifier *loopstart.ObserversList (and perhaps its Process method to Refresh akin to cloud provider Refresh also happening on loop start). This would be a new package & object (not interface) similar to the one in scale_down_candidates_observer.go.
Renaming ProvisioningClassProcessor interface to ProvisioningRequestProcessor

That should allow us to later move more logic out of RunOnce in the future. Does that make sense?

cluster-autoscaler/processors/provreq/provsioning_request_processor.go

x13n · 2024-02-08T18:45:44Z

cluster-autoscaler/processors/provreq/provsioning_request_processor.go

+
+// ProvisioningRequestProcessor process ProvisionignRequests in the cluster.
+type ProvisioningRequestProcessor interface {
+	Process() error


This is a bit weird. Processors usually process something, ideally both accepting and returning a slice of a specific type. Instead, here you're just calling back a function that doesn't accept any parameters and returns a generic error type. It is hard to say what this interface, besides the name, has to do with provisioning requests.

Yes, currently ProvisioningRequest are hidden, so we don't have a list of ProvisioningRequests to pass it here and we don't need to return anything since nothing accept the list of ProvisioningRequest.
This was initial design decision from @kisieland . But I'm open to discussion if you think that we need to change this approach.

x13n · 2024-02-08T18:48:20Z

cluster-autoscaler/processors/provreq/provsioning_request_processor.go

+	CleanUp()
+}
+
+// ProvisioningClassProcessor process ProvisionignRequests in the cluster.


So, how is this different from ProvisioningRequestProcessor? According to the descriptions, they are the same thing.

I wrote a comment below with full context, will copy the part of it that related to your question:
"Currently I'm adding support for check-capacity ProvisioningClass, but then I'll add support for atomicScaleUp ProvisioningClass. Each class will process ProvisioningRequest differently, so that's why ProvisioningRequestProcessor has a list of ProvisioningClassProcessor where each processor receives a list of ProvisioningRequests.
Initially I thought to have one interface for ProvisioningRequestProcessor and ProvisioningClassProcessor and wanted to pass nil list to ProvisioningRequestProcessor in the RunOnce() function, but @kisieland asked to have an empty input instead, so I introduced two processors."

cluster-autoscaler/processors/processors.go

cluster-autoscaler/provisioningrequest/provreqclient/testutils.go

x13n · 2024-02-09T10:11:55Z

cluster-autoscaler/core/static_autoscaler.go

@@ -507,6 +507,10 @@ func (a *StaticAutoscaler) RunOnce(currentTime time.Time) caerrors.AutoscalerErr
 		a.AutoscalingContext.DebuggingSnapshotter.SetClusterNodes(l)
 	}

+	if err := a.processors.ProvisioningRequestProcessor.Process(); err != nil {


Is it important for this to happen here specifically? If it is only about notifying the code about new loop start, can we move towards abstracting all "loop start observers" away from static_autoscaler? There's a set of objects that do some state update per loop and this one looks like a good example. The reason I'm asking is that with over 400 lines this is one of the longest functions in the whole CA codebase and throwing in unrelated function calls decreases any reader's ability to reason about what really is happening here.

ProvisioningRequestProcessor is aimed to process ProvisioningRequest conditions and check if they are expired, or the booking capacity mechanism is expired and update ProvisioningRequest conditions if needed.
This Processor should be called before ProvisioningRequestInjector (I haven't introduced it yet, it's will be in next PR), and ProvisioningRequestInjector will be a part of PodListProcessor (or it will be called just after PodListProcessor) and will be called after ProvisioningRequestFilter (which filter out real unscheduled pods that consume ProvisioningRequest from unscheduled pods to not trigger another scaleUp).

Currently we don't list ProvisioningRequests in the beginning of the loop (as we do for regular pods). I added a client to the processor and list ProvReqs inside the processor. That's why the input is empty.

Currently I'm adding support for check-capacity ProvisioningClass, but then I'll add support for atomicScaleUp ProvisioningClass. Each class will process ProvisioningRequest differently, so that's why ProvisioningRequestProcessor has a list of ProvisioningClassProcessor where each processor receives a list of ProvisioningRequests.
Initially I thought to have one interface for ProvisioningRequestProcessor and ProvisioningClassProcessor and wanted to pass nil list to ProvisioningRequestProcessor in the RunOnce() function, but @kisieland asked to have an empty input instead, so I introduced two processors.

cluster-autoscaler/core/static_autoscaler.go

cluster-autoscaler/processors/provreq/provsioning_request_processor.go

cluster-autoscaler/observers/loopstart/loopstart.go

cluster-autoscaler/processors/provreq/provsioning_request_processor.go

yaroslava-serdiuk · 2024-02-12T20:52:24Z

/label tide/merge-method-squash

x13n

Just two minor comments, otherwise LGTM.

cluster-autoscaler/go.mod

cluster-autoscaler/observers/loopstart/loopstart.go

x13n · 2024-02-14T13:08:57Z

/lgtm
/approve

k8s-ci-robot · 2024-02-14T13:09:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kisieland, x13n, yaroslava-serdiuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~cluster-autoscaler/OWNERS~~ [x13n]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

yaroslava-serdiuk · 2024-05-10T11:21:40Z

#6814

* Comment to explain why test is done on STS ownerRef * add informer argument to clusterapi provider builder This change adds the informer factory as an argument to the `buildCloudProvider` function for clusterapi so that building with tags will work properly. * Add informer argument to the CloudProviders builder. * clusterapi: add missing error check * Add instanceType/region support in Helm chart for Hetzner cloud provider * doc: cluster-autoscaler: Oracle provider: Add small security note * doc: cluster-autoscaler: Oracle provider: Add small security note * doc: cluster-autoscaler: Oracle provider: Add small security note * Update charts/cluster-autoscaler/README.md * Update Auto Labels of Subprojects * check empty ProviderID in ali NodeGroupForNode * add gce constructor with custom timeout * update README.md.gotmpl and added Helm docs for Hetzner Cloud * bump chart version * use older helm-docs version and remove empty line in values comment * add missing line breaks * Update charts/cluster-autoscaler/Chart.yaml Co-authored-by: Shubham <shubham.kuchhal@india.nec.com> * Reduce log spam in AtomicResizeFilteringProcessor Also, introduce default per-node logging quotas. For now, identical to the per-pod ones. * Bump golang in /vertical-pod-autoscaler/pkg/updater Bumps golang from 1.21.6 to 1.22.0. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump golang in /vertical-pod-autoscaler/pkg/recommender Bumps golang from 1.21.6 to 1.22.0. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump golang in /vertical-pod-autoscaler/pkg/admission-controller Bumps golang from 1.21.6 to 1.22.0. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Update Chart.yaml * Move estimatorBuilder from AutoscalingContext to Orchestrator Init * VPA: bump golang.org/x/net to fix CVE-2023-39325 The version of golang.org/x/net currently used is vulnerable to https://avd.aquasec.com/nvd/2023/cve-2023-39325/, bump it to fix that. * Bump go version. * Fix e2e test setup * helm: enable clusterapi namespace autodiscovery * Fix expectedToRegister to respect instances with nil status * add option to keep node group backoff on OutOfResource error * remove changes to backoff interface * attach errors to scale-up request and add comments * revert optionally keeping node group backoff * remove RemoveBackoff from updateScaleRequests * Add ProvisioningRequestProcessor (kubernetes#6488) * Add kube-env to MigInfoProvider * CA: GCE: add pricing for new Z3 machines * Introduce LocalSSDSizeProvider interface for GCE * Use KubeEnv in gce/templates.go * Add templateName to kube-env to ensure that correct value is cached * Add unit-tests * extract create group to function * Merged PR 1379: added retry for creatingAzureManager in case of throttled requests added retry for forceRefresh in case of throttled requests ran tests MallocNanoZone=0 go test -race k8s.io/autoscaler/cluster-autoscaler/cloudprovider/azure -- passed and commented out unit test -- commented out as it takes 10 minutes to complete func TestCreateAzureManagerWithRetryError(t *testing.T) { ctrl := gomock.NewController(t) defer ctrl.Finish() mockVMClient := mockvmclient.NewMockInterface(ctrl) mockVMSSClient := mockvmssclient.NewMockInterface(ctrl) mockVMSSClient.EXPECT().List(gomock.Any(), "fakeId").Return([]compute.VirtualMachineScaleSet{}, retry.NewError(true, errors.New("test"))).AnyTimes() mockAzClient := &azClient{ virtualMachinesClient: mockVMClient, virtualMachineScaleSetsClient: mockVMSSClient, } manager, err := createAzureManagerInternal(strings.NewReader(validAzureCfg), cloudprovider.NodeGroupDiscoveryOptions{}, config.AutoscalingOptions{}, mockAzClient) assert.Nil(t, manager) assert.NotNil(t, err) } * docs: update outdated/deprecated taints in the examples Refactor references to taints & tolerations, replacing master key with control-plane across all the example YAMLs. Signed-off-by: Feruzjon Muyassarov <feruzjon.muyassarov@intel.com> * CA FAQ: clarify the point about scheduling constraints blocking scale-down * Add warning about vendor removal to Makefile build target Signed-off-by: Feruzjon Muyassarov <feruzjon.muyassarov@intel.com> * fix: add missing ephemeral-storage resource definition * Add BuildTestNodeWithAllocatable test utility method. * Add ProvisioningRequest injector (kubernetes#6529) * Add ProvisioningRequests injector * Add test case for Accepted conditions and add supported provreq classes list * Use Passive clock * Consider preemption policy for expandable pods * Fix a bug where atomic scale-down failure could affect subsequent atomic scale-downs * Update gce_price_info.go * Migrate from satori/go.uuid to google/uuid * Delay force refresh by DefaultInterval when OCI GetNodePool call returns 404 * CA: update dependencies to k8s v1.30.0-alpha.3, go1.21.8 * Bump golang in /vertical-pod-autoscaler/pkg/admission-controller Bumps golang from 1.22.0 to 1.22.1. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Bump golang in /vertical-pod-autoscaler/pkg/updater Bumps golang from 1.22.0 to 1.22.1. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Bump golang in /vertical-pod-autoscaler/pkg/recommender Bumps golang from 1.22.0 to 1.22.1. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Update expander options for the AWS cloud provider README * Remove shadow err variable in deleteCreatedNodesWithErros func * fix memory leak in NodeDeleteTracker * CA - Add 1.29 to version compatibility matrix * ClusterAutoscaler: Put APIs in a separate go module Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> * Extend update-deps.sh so that we can automatically update k8s libraries in the apis pkg Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> * Clean up update-deps.sh Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> * Update apis version to v1.29.2 Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> * Allow to override rancher provider settings Currently it is only possible to set provider settings over yaml file. This commit introduces env variables to override URL, token and cluster name. If particular environment variable is set it overrides value supplied in yaml file. Signed-off-by: Dinar Valeev <k0da@opensuse.org> Co-authored-by: Donovan Muller <donovan.muller@absa.africa> * Bump VPA version to 1.1.0 * Deprecate the Linode Cluster Autoscaler provider Signed-off-by: Ondrej Kokes <ondrej.kokes@gmail.com> * add price info for n4 * update n4 price info format * Set "pd-balanced" as DefaultBootDiskType It is a default since v1.24 Ref: https://cloud.google.com/kubernetes-engine/docs/how-to/custom-boot-disks#specify * Clarify VPA and HPA limitations Signed-off-by: Luke Addison <lukeaddison785@gmail.com> * Update ionos-cloud-sdk-go and mocks * Update provider code * Add cloud API request metrics. * Fix and update README * Ignore ionos-cloud-sdk-go spelling * fix n4 price format * Add listManagedInstancesResults to GceCache. * [clusterapi] Do not skip nodegroups with minSize=maxSize * [clusterapi] Update tests for nodegroups with minSize=maxSize * add tests * made changes to support MIGs that use regional instance templates * modified current unit tests to support the new modifications * added comment to InstanceTemplateNameType * Ran hack/go-fmtupdate.h on mig_info_provider_test.go * Use KubeEnv in gce/templates.go * Add templateName to kube-env to ensure that correct value is cached * rebased and resolved conflicts * added fix for unit tests * changed InstanceTemplateNameType to InstanceTemplateName * separated url parser to its own function, created unit test for the function * separated url parser to its own function, created unit test for the function * added unit test with regional MIG * Migrate GCE client to server side operation wait * Track type of node group created/deleted in auto-provisioned group metrics. * trigger tests * fix comment * Add AtomicScaleUp method to NodeGroup interface * Add an option to Cluster Autoscaler that allows triggering new loops more frequently: based on new unschedulable pods and every time a previous iteration was productive. * Refactor StartDeletion usage patterns and enforce periodic scaledown status processor calls. * Bump golang to 1.22 * updated admission-controller to have adjustable --min-tls-version and --tls-ciphers * CA: Move the ProvisioningRequest CRD to apis module Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> * Bump default VPA version to 1.1.0 As part of the 1.1.0 release: kubernetes#6388 * Format README * Add chart versions * Add script to update required chart versions in README * Add chart version column in version matrix * Move cluster-autoscaler update-chart-version-readme script to /hack * Only check recent revisions when updating README * Update min cluster-autoscaler chart for Kubernetes 1.29 * Remove unused NodeInfoProcessor * Fix broken link in README.md to point to equinixmetal readme * review comments - simplify retry logic * CA: Before we perform go test, synchronizing go vendor Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> * Cleanup ProvReq wrapper * Make the Estimate func accept pods grouped. The grouping should be made by the schedulability equivalence meaning we can introduce optimizations to the binpacking. Introduce a benchmark that estimates capacity needed for 51k pods, which can be grouped to two equivalence groups 50k and 1k. * Update CAPI docs Add a link to the sample manifest and update the image used in the example. Signed-off-by: Lennart Jern <lennart.jern@est.tech> * Bump golang in /vertical-pod-autoscaler/pkg/updater Bumps golang from 1.22.1 to 1.22.2. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Bump golang in /vertical-pod-autoscaler/pkg/admission-controller Bumps golang from 1.22.1 to 1.22.2. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Bump golang in /vertical-pod-autoscaler/pkg/recommender Bumps golang from 1.22.1 to 1.22.2. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Introduce binbacking optimization for similar pods. The optimization uses the fact that pods which are equivalent do not need to be check multiple times against already filled nodes. This changes the time complexity from O(pods*nodes) to O(pods). * CA: Fix apis vendoring * Add g6 EC2 instance type for AWS * Copyright boilerplate * Lower errors verbosity for kube-env label missing * parentController may be nil when owner isn't scalable * Update ProvisioningClass API Group * Fix Autoscaling for worker nodes with invalid ProviderID This change fixes a bug that arises when the user's cluster includes worker nodes not from Hetzner Cloud, such as a Hetzner Dedicated server or any server resource other than Hetzner. It also corrects the behavior when a server has been physically deleted from Hetzner Cloud. Signed-off-by: Maksim Paskal <paskal.maksim@gmail.com> * Add tests for Pods owner that doesn't implement /scale * Add provreqOrchestrator that handle ProvReq classes (kubernetes#6627) * Add provreqOrchestrator that handle ProvReq classes * Review remarks * Review remarks * Cluster Autoscaler: Sync k8s.io dependencies to k/k v1.30.0, bump Go to 1.22.2 * [v1.30] fix(hetzner): hostname label is not considered The Node Group info we currently return does not include the `kubernetes.io/hostname` label, which is usually set on every node. This causes issues when the user has an unscheduled pod with a `topologySpreadConstraint` on `topologyKey: kubernetes.io/hostname`. cluster-autoscaler is unable to fulfill this constraint and does not scale up any of the node groups. Related to kubernetes#6715 * Remove the flag for enabling ProvisioningRequests The API is not stable yet, we don't want people to depend on the current version. * fix: scale up broken for providers not implementing NodeGroup.GetOptions() Properly handle calls to `NodeGroup.GetOptions()` that return `cloudprovider.ErrNotImplemented` in the scale up path. * Add --enable-provisioning-requests flag * [cluster-autoscaler-release-1.30] Fix ProvisioningRequest update (kubernetes#6825) * Fix ProvisioningRequest update * Review remarks --------- Co-authored-by: Yaroslava Serdiuk <yaroslava@google.com> * Update k/k vendor to 1.30.1 for CA 1.30 * sync changes * added sync changes file * golint fix * update vpa vendor * fixed volcengine * ran gofmt * synched azure * synched azure * synched IT * removed IT log file * addressed review comments --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Feruzjon Muyassarov <feruzjon.muyassarov@intel.com> Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> Signed-off-by: Dinar Valeev <k0da@opensuse.org> Signed-off-by: Ondrej Kokes <ondrej.kokes@gmail.com> Signed-off-by: Luke Addison <lukeaddison785@gmail.com> Signed-off-by: Lennart Jern <lennart.jern@est.tech> Signed-off-by: Maksim Paskal <paskal.maksim@gmail.com> Co-authored-by: Kubernetes Prow Robot <20407524+k8s-ci-robot@users.noreply.github.com> Co-authored-by: David Benque <david.benque@datadoghq.com> Co-authored-by: michael mccune <msm@opbstudios.com> Co-authored-by: shubham82 <shubham.kuchhal@india.nec.com> Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com> Co-authored-by: Niklas Rosenstein <niklas.rosenstein@helsing.ai> Co-authored-by: Ky-Anh Huynh <kyanh@viettug.org> Co-authored-by: Niklas Rosenstein <rosensteinniklas@gmail.com> Co-authored-by: Guy Templeton <guyjtempleton@googlemail.com> Co-authored-by: daimaxiaxie <44503972+daimaxiaxie@users.noreply.github.com> Co-authored-by: daimaxiaxie <codexiaxie@163.com> Co-authored-by: Michal Pitr <michalpitr@google.com> Co-authored-by: Daniel Kłobuszewski <danielmk@google.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Artur Żyliński <azylinski@google.com> Co-authored-by: Alvaro Aleman <aaleman@confluent.io> Co-authored-by: Marco Voelz <marco.voelz@sap.com> Co-authored-by: Jack Francis <jackfrancis@gmail.com> Co-authored-by: Yarin Miran <yarin@wiz.io> Co-authored-by: Will Bowers <22203232+wllbo@users.noreply.github.com> Co-authored-by: Yaroslava Serdiuk <yaroslava@google.com> Co-authored-by: Bartłomiej Wróblewski <bwroblewski@google.com> Co-authored-by: Anish Shah <shah.anish07@gmail.com> Co-authored-by: Mahmoud Atwa <mahmoudatwa@google.com> Co-authored-by: pawel siwek <pawelsiwek@google.com> Co-authored-by: Miranda Craghead <mcraghead@microsoft.com> Co-authored-by: Feruzjon Muyassarov <feruzjon.muyassarov@intel.com> Co-authored-by: Kuba Tużnik <jtuznik@google.com> Co-authored-by: Johnnie Ho <johnnieho89@gmail.com> Co-authored-by: Walid Ghallab <walidghallab@google.com> Co-authored-by: Karol Wychowaniec <kawych@google.com> Co-authored-by: oksanabaza <obazylie@redhat.com> Co-authored-by: Vijay Bhargav Eshappa <vijay.bhargav.eshappa@oracle.com> Co-authored-by: David <drmorr@appliedcomputing.io> Co-authored-by: Damika Gamlath <damika@google.com> Co-authored-by: Ashish Pani <ashishpani988@gmail.com> Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com> Co-authored-by: Dinar Valeev <k0da@opensuse.org> Co-authored-by: Donovan Muller <donovan.muller@absa.africa> Co-authored-by: Luiz Antonio <luizaoj@google.com> Co-authored-by: Ondrej Kokes <ondrej.kokes@gmail.com> Co-authored-by: Yuan <yuanwangyw@google.com> Co-authored-by: Luke Addison <lukeaddison785@gmail.com> Co-authored-by: Mario Valderrama <mario.valderrama@ionos.com> Co-authored-by: Max Fedotov <m.a.fedotov@gmail.com> Co-authored-by: Daniel-Redeploy <84455776+Daniel-Redeploy@users.noreply.github.com> Co-authored-by: Edwinhr716 <edandres249@gmail.com> Co-authored-by: Maksym Fuhol <mfuhol@google.com> Co-authored-by: Allen Mun <allen.mun197@gmail.com> Co-authored-by: mewa <marcin.k.chmiel@gmail.com> Co-authored-by: Aayush Rangwala <ayush.rangwala@gmail.com> Co-authored-by: prachigandhi <prachigandhi@microsoft.com> Co-authored-by: Daniel Gutowski <danielgutowski@google.com> Co-authored-by: Lennart Jern <lennart.jern@est.tech> Co-authored-by: mendelski <mendelski@google.com> Co-authored-by: ceuity <everland7942@gmail.com> Co-authored-by: Maksim Paskal <paskal.maksim@gmail.com> Co-authored-by: Julian Tölle <julian.toelle@hetzner-cloud.de> Co-authored-by: k8s-infra-cherrypick-robot <90416843+k8s-infra-cherrypick-robot@users.noreply.github.com>

k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/cluster-autoscaler labels Jan 31, 2024

k8s-ci-robot requested review from BigDarkClown and x13n January 31, 2024 10:32

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 31, 2024

yaroslava-serdiuk force-pushed the provreq-reconcile branch 3 times, most recently from 0e74dcc to 27484d1 Compare January 31, 2024 11:25

kisieland mentioned this pull request Feb 5, 2024

[Site] Update provisioning admission check controller public doc with supported CA version kubernetes-sigs/kueue#1666

Merged

kisieland reviewed Feb 5, 2024

View reviewed changes

cluster-autoscaler/provisioningrequest/checkcapacity/processor.go Show resolved Hide resolved

cluster-autoscaler/provisioningrequest/checkcapacity/processor.go Outdated Show resolved Hide resolved

cluster-autoscaler/processors/processors.go Outdated Show resolved Hide resolved

yaroslava-serdiuk force-pushed the provreq-reconcile branch from 27484d1 to c9a1ef0 Compare February 6, 2024 13:38

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 6, 2024

yaroslava-serdiuk force-pushed the provreq-reconcile branch 5 times, most recently from 538c5e9 to 5ba9f48 Compare February 7, 2024 11:09

kisieland approved these changes Feb 7, 2024

View reviewed changes

cluster-autoscaler/provisioningrequest/checkcapacity/processor.go Show resolved Hide resolved

kisieland reviewed Feb 7, 2024

View reviewed changes

cluster-autoscaler/provisioningrequest/checkcapacity/processor.go Show resolved Hide resolved

kisieland reviewed Feb 7, 2024

View reviewed changes

cluster-autoscaler/core/static_autoscaler.go Outdated Show resolved Hide resolved

yaroslava-serdiuk force-pushed the provreq-reconcile branch 4 times, most recently from 628ccc0 to 1f5d546 Compare February 7, 2024 21:02

x13n requested changes Feb 9, 2024

View reviewed changes

yaroslava-serdiuk force-pushed the provreq-reconcile branch 2 times, most recently from 4e737b6 to 9492b23 Compare February 12, 2024 15:03

yaroslava-serdiuk force-pushed the provreq-reconcile branch from 9492b23 to 28376c7 Compare February 12, 2024 15:07

yaroslava-serdiuk requested a review from x13n February 12, 2024 15:38

yaroslava-serdiuk force-pushed the provreq-reconcile branch from 28376c7 to d4337f5 Compare February 12, 2024 15:53

x13n requested changes Feb 12, 2024

View reviewed changes

yaroslava-serdiuk force-pushed the provreq-reconcile branch 2 times, most recently from 9eb2638 to 54733b3 Compare February 12, 2024 20:50

yaroslava-serdiuk requested a review from x13n February 12, 2024 20:50

k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 12, 2024

x13n requested changes Feb 14, 2024

View reviewed changes

cluster-autoscaler/go.mod Outdated Show resolved Hide resolved

cluster-autoscaler/observers/loopstart/loopstart.go Outdated Show resolved Hide resolved

Add ProvisioningRequestProcessor

ea387cd

yaroslava-serdiuk force-pushed the provreq-reconcile branch from 54733b3 to ea387cd Compare February 14, 2024 12:11

k8s-ci-robot assigned x13n Feb 14, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2024

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2024

k8s-ci-robot merged commit 5286b3f into kubernetes:master Feb 14, 2024
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ProvisioningRequestProcessor #6488

Add ProvisioningRequestProcessor #6488

yaroslava-serdiuk commented Jan 31, 2024 •

edited

Loading

kisieland left a comment

k8s-ci-robot commented Feb 7, 2024

x13n left a comment

x13n Feb 8, 2024

yaroslava-serdiuk Feb 9, 2024

x13n Feb 8, 2024

yaroslava-serdiuk Feb 9, 2024

x13n Feb 9, 2024

yaroslava-serdiuk Feb 9, 2024

yaroslava-serdiuk commented Feb 12, 2024

x13n left a comment

x13n commented Feb 14, 2024

k8s-ci-robot commented Feb 14, 2024

yaroslava-serdiuk commented May 10, 2024

Add ProvisioningRequestProcessor #6488

Add ProvisioningRequestProcessor #6488

Conversation

yaroslava-serdiuk commented Jan 31, 2024 • edited Loading

What type of PR is this?

What this PR does / why we need it:

kisieland left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Feb 7, 2024

x13n left a comment

Choose a reason for hiding this comment

x13n Feb 8, 2024

Choose a reason for hiding this comment

yaroslava-serdiuk Feb 9, 2024

Choose a reason for hiding this comment

x13n Feb 8, 2024

Choose a reason for hiding this comment

yaroslava-serdiuk Feb 9, 2024

Choose a reason for hiding this comment

x13n Feb 9, 2024

Choose a reason for hiding this comment

yaroslava-serdiuk Feb 9, 2024

Choose a reason for hiding this comment

yaroslava-serdiuk commented Feb 12, 2024

x13n left a comment

Choose a reason for hiding this comment

x13n commented Feb 14, 2024

k8s-ci-robot commented Feb 14, 2024

yaroslava-serdiuk commented May 10, 2024

yaroslava-serdiuk commented Jan 31, 2024 •

edited

Loading