Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup ProvReq wrapper #6670

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Cleanup ProvReq wrapper #6670

merged 1 commit into from
Apr 15, 2024

Conversation

yaroslava-serdiuk
Copy link
Contributor

What type of PR is this?

/kind cleanup

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/cluster-autoscaler labels Mar 29, 2024
@yaroslava-serdiuk
Copy link
Contributor Author

/assign @towca

@towca
Copy link
Collaborator

towca commented Apr 9, 2024

/lgtm
/approve
/hold

The change itself LGTM, but I'm wondering about the motivation behind it. It seems like the wrapper was designed as a translation layer between different ProvReq API versions. Do you think this won't be needed after all? What happens when we introduce v1 ProvReq?

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Apr 9, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: towca, yaroslava-serdiuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2024
@yaroslava-serdiuk
Copy link
Contributor Author

/unhold

API is unlikely to change much, but there are a lot of code duplication in current version of wrapper.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2024
@k8s-ci-robot k8s-ci-robot merged commit b5cd900 into kubernetes:master Apr 15, 2024
6 checks passed
@yaroslava-serdiuk
Copy link
Contributor Author

#6814

@yaroslava-serdiuk yaroslava-serdiuk deleted the provreqwrapper branch May 28, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer Awaiting requested review from feiskyer

@vadasambar vadasambar Awaiting requested review from vadasambar

Assignees

@towca towca

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yaroslava-serdiuk @towca @k8s-ci-robot