-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ProvReq annotations to new prefix #6874
Conversation
Hi @kisieland. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign @towca |
e0f4b75
to
09848ab
Compare
/ok-to-test |
/lgtm |
/assign @x13n |
/unassign @x13n |
/unhold |
09848ab
to
9b3265e
Compare
cluster-autoscaler/apis/provisioningrequest/autoscaling.x-k8s.io/v1beta1/types.go
Show resolved
Hide resolved
9b3265e
to
527b22a
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kisieland, towca The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Use autoscaling.x-k8s.io rather than cluster-autoscaler.kubernetes.io
527b22a
to
296e79a
Compare
/lgtm |
/cherry-pick cluster-autoscaler-release-1.30 |
@yaroslava-serdiuk: #6874 failed to apply on top of branch "cluster-autoscaler-release-1.30":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Use autoscaling.x-k8s.io rather than cluster-autoscaler.kubernetes.io
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
As part of #6759 new annotation scheme was suggested