Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for check-capacity Provisioning class #6904

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Add documentation for check-capacity Provisioning class #6904

merged 1 commit into from
Jun 20, 2024

Conversation

yaroslava-serdiuk
Copy link
Contributor

What type of PR is this?

/kind documentation

#6814

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Jun 7, 2024
@k8s-ci-robot k8s-ci-robot added area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 7, 2024
@yaroslava-serdiuk yaroslava-serdiuk changed the title Add documentation for ProvisioningRequest Add documentation for check-capacity Provisioning class Jun 7, 2024
@yaroslava-serdiuk
Copy link
Contributor Author

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 7, 2024
alculquicondor
alculquicondor reviewed Jun 7, 2024
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2024
kisieland
kisieland approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@kisieland kisieland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit otherwise
/lgtm

cluster-autoscaler/FAQ.md Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

@kisieland: changing LGTM is restricted to collaborators

In response to this:

One nit otherwise
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2024
cortespao
cortespao reviewed Jun 7, 2024
View reviewed changes
Copy link

@cortespao cortespao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sending a couple of suggestions. Thanks!

cluster-autoscaler/FAQ.md Show resolved Hide resolved
cluster-autoscaler/FAQ.md Outdated Show resolved Hide resolved
cluster-autoscaler/FAQ.md Show resolved Hide resolved
cluster-autoscaler/FAQ.md Show resolved Hide resolved
cluster-autoscaler/FAQ.md Show resolved Hide resolved
@yaroslava-serdiuk
Copy link
Contributor Author

/assign @MaciekPytel

MaciekPytel
MaciekPytel reviewed Jun 20, 2024
View reviewed changes
cluster-autoscaler/FAQ.md Outdated
### How can I use ProvisioningRequest to run batch workloads

ProvisioningRequest (or ProvReq) is a new namespaced Custom Resource that allows you to ask CA for capacity for groups of pods. For a detailed explanation of the ProvisioningRequest API, please refer to the
[proposal](https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/proposals/provisioning-request.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that up to date? IIRC we've made some changes from the original design during the implementation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think implementation details are not correct, but the API didn't change except of suffix, so I think it's ok to refer this proposal for detailed explanation of the ProvisioningRequest API.
I added "original proposal" to emphasise that some other details of the proposal could be outdated.

@MaciekPytel
Copy link
Contributor

/approve
/hold
Left a few comments, adding hold to allow addressing them. Please feel free to remove hold without additional review from me if I'm not responsive enough

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 20, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kisieland, MaciekPytel, yaroslava-serdiuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2024
@alculquicondor
Copy link
Member

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 20, 2024
@k8s-ci-robot k8s-ci-robot merged commit a9fe7e3 into kubernetes:master Jun 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortespao cortespao cortespao left review comments

@MaciekPytel MaciekPytel MaciekPytel left review comments

@alculquicondor alculquicondor alculquicondor left review comments

@kisieland kisieland kisieland approved these changes

@BigDarkClown BigDarkClown Awaiting requested review from BigDarkClown

@vadasambar vadasambar Awaiting requested review from vadasambar

Assignees

@alculquicondor alculquicondor

@MaciekPytel MaciekPytel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yaroslava-serdiuk @k8s-ci-robot @MaciekPytel @alculquicondor @kisieland @cortespao