Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InitContainers dont work by default when moving from unversioned client to client-go #142

Closed
krmayankk opened this issue Mar 10, 2017 · 5 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@krmayankk
Copy link

  • I was Migrating an app using Init Containers from unversioned client to client-go
  • All i needed to do in the unversioned client, was populate api.Container into InitContainers field of the PodSpec.
  • the migrated app stopped working in client-go.
  • i had to explictily enable serialization to annotations to make the init containers work in client-go.

I think that is a bad user experience. By default Init Containers or any other alpha feature should work, without requiring any special serialization.

I had to call the following function to make this work https://github.com/kubernetes/kubernetes/blob/master/pkg/api/v1/pod/util.go#L91
which is not part of the client-go code. So i had to duplicate that in my app.

@caesarxuchao
Copy link
Member

@smarterclayton we had dealt with this when we migrated kubernetes to use versioned client. Is initcontainer going to be stable soon? If so, i don't want to import those conversion functions to client-go.

@ericchiang
Copy link
Contributor

Looks like initContainers will be available as a field in 1.6 kubernetes/kubernetes#38382

Which "unversioned" version where you using? I don't think those fields were added until 1.6.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 22, 2017
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 21, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

6 participants