-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add firewall rules and ing class clarifications #1672
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
@@ -78,6 +78,8 @@ Next we create a couple of Ingress rules | |||
kubectl create -f examples/ingress.yaml | |||
``` | |||
|
|||
If your version of Kubernetes is higher than 1.3, you can restrict the ingress usage to NGINX with this annotation :`kubernetes.io/ingress.class: "nginx"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please surface this in the requirements section instead, something like:
if you're running multiple ingress controllers, or running on a cloudprovider that natively handles
ingress, you need to specify the annotation `kubernetes.io/ingress.class: "nginx"` in all ingresses
that you would like this controller to claim. Not specifying the annotation will lead to multiple
ingress controllers claiming the same ingress. Specifying the wrong value will result in all ingress
controllers ignoring the ingress. Multiple ingress controllers running in the same cluster was not
supported in Kubernetes versions < 1.3.
@bprashanth fine to me, updated with your suggestion |
### Running multiple ingress controllers | ||
|
||
If you're running multiple ingress controllers, or running on a cloudprovider that natively handles | ||
ingress, you need to specify the annotation kubernetes.io/ingress.class: "nginx" in all ingresses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please quote this, ie kubernetes.io/ingress.class: "nginx"
LGTM just one nit |
LGTM, please sign CLA |
I signed it! |
CLAs look good, thanks! |
Automatic merge from submit-queue |
Automatic merge from submit-queue Add firewall rules and ing class clarifications
This change is