This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
[nginx-ingress-controller] Add external authentication using auth_request #1796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
the
cncf-cla: yes
aledbf
force-pushed
the
subrequest-auth
branch
2 times, most recently
from
dec4a7a
to
d9214bd
Compare
bprashanth
reviewed
Sep 28, 2016
|
|
||
| var ( | ||
| // ErrMissingAnnotations is returned when the ingress rule | ||
| // does not contains annotations related with authentication |
There was a problem hiding this comment.
s/does not contains/does not contain/
| @@ -723,6 +724,12 @@ func (lbc *loadBalancerController) getUpstreamServers(ngxCfg config.Configuratio | |||
| glog.V(3).Infof("error reading CORS annotation in Ingress %v/%v: %v", ing.GetNamespace(), ing.GetName(), err) | |||
| } | |||
|
|
|||
| ra, err := authreq.ParseAnnotations(ing) | |||
There was a problem hiding this comment.
controller.go (last commit)
aledbf
force-pushed
the
subrequest-auth
branch
from
d9214bd
to
064df64
Compare
|
Saw the related discussion on the bug, can you add an example of how to use this, and how that enables further integration with things like the oauth_proxy? (fine if you want to do this in a follow up) |
|
I think your failure is legit |
oops I forgot to use go 1.6 features (t.Run is a new thing in 1.7) |
aledbf
force-pushed
the
subrequest-auth
branch
2 times, most recently
from
d3b6ce1
to
1dc197e
Compare
aledbf
force-pushed
the
subrequest-auth
branch
from
1dc197e
to
a7baeb0
Compare
aledbf
changed the title
|
Automatic merge from submit-queue |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1492
This change is