Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect secret from deletion while it is in-use #2639

Closed
4 tasks
mkimuram opened this issue Apr 20, 2021 · 13 comments
Closed
4 tasks

Protect secret from deletion while it is in-use #2639

mkimuram opened this issue Apr 20, 2021 · 13 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@mkimuram
Copy link
Contributor

mkimuram commented Apr 20, 2021

Enhancement Description

  • One-line enhancement description (can be used as a release note): Protect secret from deletion while it is in-use
  • Kubernetes Enhancement Proposal: Add KEP for Secret/ConfigMap protection #2640
  • Discussion Link: Protect secret from deletion while it is in-use kubernetes#101130
  • Primary contact (assignee): @mkimuram
  • Responsible SIGs: @kubernetes/sig-storage-feature-requests
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y): 1.23
    • Beta release target (x.y): 1.24
    • Stable release target (x.y): 1.26
  • Alpha
    • KEP (k/enhancements) update PR(s):
    • Code (k/k) update PR(s):
    • Docs (k/website) update PR(s):

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. kind/feature Categorizes issue or PR as related to a new feature. labels Apr 20, 2021
@JamesLaverack
Copy link
Member

/stage alpha
/milestone v1.22

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label May 11, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 11, 2021
@JamesLaverack JamesLaverack added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label May 11, 2021
@reylejano
Copy link
Member

Hi @mkimuram ,

1.22 Enhancements team here. I see that the PR for the KEP is open at the time of this comment in PR 2640.

The 1.22 Enhancements Freeze is coming up on Thursday, May 13 at 23:59:59 pst.
For an enhancement to successfully make the 1.22 Enhancement Freeze, it requires the following:

  • A merged KEP README.md and kep.yaml in k/enhancements and follows the kep template
    • KEP README.md must include all sections in the template including Graduation Criteria for the stage going in to (e.g. alpha, beta, stable), a Test Plan
    • The kep.yaml must include the following key:value pairs
      • state: implementable
      • latest-milestone: "v1.22"
      • appropriate alpha, beta, stable milestones
  • An approved Production Readiness Review (PRR), read this to learn how to submit a PRR

Feel free to reach out if you have any questions

@reylejano
Copy link
Member

reylejano commented May 13, 2021

Hi @mkimuram, the 1.22 Enhancements Freeze starts at 23:59:59 pst today, May 13.
For this enhancement to make the 1.22 Enhancements Freeze, the changes listed in my earlier comment have to be merged by 23:59:59 pst today, May 13.

PR 2640 is open to address the changes required to make the 1.22 Enhancements Freeze but must merge by 23:59:59 pst today, May 13

@mkimuram
Copy link
Contributor Author

/assign @xing-yang
/cc @johnbelamaric @liggitt

@JamesLaverack
Copy link
Member

Hi @mkimuram, 1.22 Enhancements Lead here. 👋 With enhancements freeze now in effect we are removing this enhancement from the 1.22 release.

Feel free to file an exception to add this back to the release. If you plan to do so, please file this as early as possible.

Thanks!
/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.22 milestone May 14, 2021
@JamesLaverack JamesLaverack added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels May 14, 2021
@xing-yang
Copy link
Contributor

/milestone v1.23

@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 30, 2021
@salaxander salaxander added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Aug 31, 2021
@lauralorenz
Copy link
Contributor

Hi @mkimuram! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze on Thursday 09/09.

If I understand correctly you are targeting alpha stage for release 1.23.

Here's where this enhancement currently stands:

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable (filled out in PR, not merged)
  • KEP has a test plan section filled out. (filled out in PR, not merged)
  • KEP has up to date graduation criteria. (filled out in PR, not merged)
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (filled out in PR, not merged)

Starting with 1.23, we have implemented a soft freeze on production readiness reviews beginning TOMORROW, Thursday 09/02. It looks like you have your PRR questionnaire filled out in your PR and a PRR reviewer assigned, so you are on track for the soft freeze tomorrow!

Thanks!

@lauralorenz
Copy link
Contributor

Hi @mkimuram! 1.23 Enhancements team here again. Just doing my rounds and I saw in #2640 (comment) that this is expected to slip the deadline for 1.23 enhancements freeze tonight. If that's true when you have a chance to confirm/remove from milestone/update the enhancements issue OP with the new targets, that would be great! Thanks!

@salaxander
Copy link
Contributor

Hi, 1.23 Enhancements Lead here 👋. With enhancements freeze now in effect, this enhancement has not met the criteria for the freeze and has been removed from the milestone.

As a reminder, the criteria for enhancements freeze is:

  • KEP is merged into k/enhancements repo with up to date latest milestone and stage.
  • KEP status is marked as implementable.
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review for the correct stage that has been completed and merged into k/enhancements.

Feel free to file an exception to add this back to the release. If you plan to do so, please file this as early as possible.

Thanks!
/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.23 milestone Sep 10, 2021
@salaxander salaxander added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Sep 10, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 9, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 8, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests

8 participants