Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go workspaces for k/k #4402

Closed
5 tasks done
thockin opened this issue Jan 14, 2024 · 13 comments · Fixed by #4531
Closed
5 tasks done

Go workspaces for k/k #4402

thockin opened this issue Jan 14, 2024 · 13 comments · Fixed by #4531
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/release Categorizes an issue or PR as relevant to SIG Release.
Milestone

Comments

@thockin
Copy link
Member

thockin commented Jan 14, 2024

Enhancement Description

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 14, 2024
@thockin thockin added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. labels Jan 14, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 14, 2024
@liggitt liggitt added the lead-opted-in Denotes that an issue has been opted in to a release label Feb 1, 2024
@liggitt liggitt added this to the v1.30 milestone Feb 1, 2024
@salehsedghpour
Copy link

Hello @jpbetz and @liggitt 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage stable for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.30.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

The status of this enhancement is marked as Tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well, I couldn't find any related PR regarding this KEP in k/enhancements. Thank you!

@salehsedghpour salehsedghpour moved this to Tracked for Enhancements Freeze in 1.30 Enhancements Tracking Feb 5, 2024
@drewhagen
Copy link
Member

drewhagen commented Feb 15, 2024

Hello @jpbetz and @liggitt 👋, 1.30 Docs Lead here.

Does this enhancement work planned for 1.30 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@fkautz
Copy link
Member

fkautz commented Feb 16, 2024

Hi @thockin

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.
Here's the 1.30 Release Calendar

@ash2k
Copy link
Member

ash2k commented Feb 19, 2024

Very excited to see this. Thank you!

I'd like to draw a little bit of attention to a related issue: kubernetes/apiextensions-apiserver#57. Perhaps it'll become easier to address once it's easier to have modules thanks to using workspaces.

@thockin
Copy link
Member Author

thockin commented Feb 20, 2024

I don't think this needs user-facing docs, but a blog post seems possible. I am sort of AFK this week but will look at what I can do.

@fkautz
Copy link
Member

fkautz commented Feb 22, 2024

Hi @thockin,

Thank you for opting in for a 1.30 Feature Blog -- I know you are out this week, but can you open a placeholder PR by February 26th?

@salehsedghpour
Copy link

salehsedghpour commented Feb 22, 2024

Hey again @jpbetz, @liggitt, and @thockin 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

With this, it is now marked as at risk for code freeze for the v1.30 Code Freeze!

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@salehsedghpour salehsedghpour moved this from Tracked for Enhancements Freeze to At Risk for Code Freeze in 1.30 Enhancements Tracking Feb 22, 2024
@thockin
Copy link
Member Author

thockin commented Feb 25, 2024

The main gengo change has landed (kubernetes/gengo#259).

A small followup is needed (kubernetes/gengo#261) and then kube-openapi can land (kubernetes/kube-openapi#457). After that I will rebase kubernetes/kubernetes#122624 for k/k.

@thockin
Copy link
Member Author

thockin commented Feb 26, 2024

kubernetes/kube-openapi#458 is pending now.

@fkautz
Copy link
Member

fkautz commented Feb 26, 2024

@thockin

Hello! This is a friendly reminder that the placeholder PR is due on Feb 27 (tomorrow as of the time of writing this comment).

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
Here's the 1.30 Release Calendar

Cheers,
Frederick

@thockin
Copy link
Member Author

thockin commented Feb 26, 2024

kubernetes/website#45358

@thockin
Copy link
Member Author

thockin commented Mar 1, 2024

Merged!

@salehsedghpour
Copy link

With this being merged, this enhancement can be marked as tracked.

@salehsedghpour salehsedghpour moved this from At Risk for Code Freeze to Tracked for Code Freeze in 1.30 Enhancements Tracking Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
Status: Tracked for Code Freeze
Development

Successfully merging a pull request may close this issue.

8 participants