404 instead of 503 without working endpoints

[nailgun]

NGINX Ingress controller version: 0.9.0-beta.15

Kubernetes version (use kubectl version): v1.7.6

Environment:

• Cloud provider or hardware configuration: GKE
• OS (e.g. from /etc/os-release): cos

What happened:
I get 404 from ingress controller if exposed deployment doesn't have endpoints.

What you expected to happen:
It should return 503 I think.

How to reproduce it (as minimally and precisely as possible):

• create deployment
• expose it as a service
• create ingress
• scale deployment to 0
• curl -v INGRESS_URL

Anything else we need to know:
Looks like this condition evaluates to true. But I think it shouldn't.

This is part of generated nginx.conf for the resource:

            proxy_http_version                      1.1;

            proxy_cookie_domain                     off;
            proxy_cookie_path                       off;

            # In case of errors try the next upstream server before returning an error
            proxy_next_upstream                     error timeout invalid_header http_502 http_503 http_504;

            proxy_pass http://upstream-default-backend;
        }

I think there should be return 503; instead of proxy_pass http://upstream-default-backend;.

[aledbf]

Closing. This is fixed in master. Next version will include this fix #1513

[nailgun]

Thanks