Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nginx.tmpl] Cors add_header always #1683

Closed
talset opened this issue Nov 10, 2017 · 0 comments · Fixed by #1696
Closed

[nginx.tmpl] Cors add_header always #1683

talset opened this issue Nov 10, 2017 · 0 comments · Fixed by #1696

Comments

@talset
Copy link

talset commented Nov 10, 2017

According http://nginx.org/en/docs/http/ngx_http_headers_module.html there's an option named always that always returns the header field regardless of the response code.

It is useful particularly on cors headers.

Do you think it worst it to add a new annotation like annotationCorsAlways in order to define a variable like $cors.CorsAlways = "" or "always"

Example :

add_header 'Access-Control-Allow-Origin' '{{ $cors.CorsAllowOrigin }} {{ $cors.CorsAlways }}';
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant