Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass request headers to error backend #273

Closed
foxylion opened this issue Feb 14, 2017 · 4 comments · Fixed by #275
Closed

Pass request headers to error backend #273

foxylion opened this issue Feb 14, 2017 · 4 comments · Fixed by #275
Labels

Comments

@foxylion
Copy link
Contributor

I got the ingress error backend working and can now serve custom error pages. Perfect!

One requirement for us is, that the error pages are internationalized, therefore I would like to rely on the http headers of the client (Accept-Language). But when requesting the error page the nginx does only provide the X-Format and X-Code headers.

Maybe it would be a good idea to pass all other headers to the error backend?

@aledbf
Copy link
Member

aledbf commented Feb 14, 2017

@foxylion added to the TODO list for the next version. The reason why the headers are not passed is because we make a subrequest using lua here and we only specify the status code.

I will open a PR to pass all the headers from the request.

@foxylion
Copy link
Contributor Author

@alebdf Yes, I also saw this behavior in the source.

Thanks a lot for your effort to get that working!

@foxylion
Copy link
Contributor Author

@aledbf This is awesome, thank you!

@foxylion
Copy link
Contributor Author

With the new release, I can confirm, this is working.
Thanks for the improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants