Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom error backend does not set content-type correctly #274

Closed
foxylion opened this issue Feb 14, 2017 · 3 comments
Closed

Custom error backend does not set content-type correctly #274

foxylion opened this issue Feb 14, 2017 · 3 comments

Comments

@foxylion
Copy link
Contributor

When adding a custom error backend which also provides responses for X-Format=json the nginx does not set the Content-Type header correclty (it's actually text/html).

I think the best case could be that nginx is passing all headers from the error backend to the client. So the error backend can set any Content-Type (and additional headers). (Currently nginx just ignores the headers)

@aledbf
Copy link
Member

aledbf commented Feb 20, 2017

@foxylion fixed in #275. Please reopen if you still have issues.
Fix included in next release #303

@aledbf aledbf closed this as completed Feb 20, 2017
@foxylion
Copy link
Contributor Author

@aledbf I did also review the pull request #275 but could not find an evidence that this is now fixed. Can you guide me to the change which fixes this (I'm just curious 😃).

@foxylion
Copy link
Contributor Author

With the new release, I can confirm, this is working.
Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants