Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nginx still doesn't respect kubernetes.io/ingress.class #412

Closed
goddva opened this issue Mar 9, 2017 · 4 comments · Fixed by #418
Closed

nginx still doesn't respect kubernetes.io/ingress.class #412

goddva opened this issue Mar 9, 2017 · 4 comments · Fixed by #418

Comments

@goddva
Copy link

goddva commented Mar 9, 2017

Created image from master, deployed. After deploy I get into a race between gce and nginx-controller both trying to update the ingresses.

2017-03-09T14:12:44.788002059Z I0309 14:12:44.787978       5 launch.go:99] Watching for ingress class: custom-nginx
...
2017-03-09T14:12:44.868066319Z I0309 14:12:44.867939       5 controller.go:172] ignoring add for ingress jenkins based on annotation kubernetes.io/ingress.class
...
2017-03-09T14:13:15.142941425Z I0309 14:13:15.142918       5 status.go:154] I am the new status update leader
2017-03-09T14:13:44.875652937Z I0309 14:13:44.875617       5 status.go:275] updating Ingress jenkins/jenkins status to [{x.x.x.x }]

When I added a debug line in updateStatus, and logged the result of ing.GetAnnotations()["kubernetes.io/ingress.class"], is see that its updating an ingress with wrong ingress.class.

@tonglil
Copy link
Contributor

tonglil commented Mar 9, 2017

What is the annotation you have in your Ingress resource?

@goddva
Copy link
Author

goddva commented Mar 9, 2017

I have tried this where I want it to be picked up;

apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: test
  annotations:
    kubernetes.io/tls-acme: "true"
    kubernetes.io/ingress.class: "custom-nginx"
    ...

but my jenkins has this;

apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: jenkins
  namespace: jenkins
  annotations:
    kubernetes.io/ingress.global-static-ip-name: "jenkins-frontend"
    kubernetes.io/ingress.class: "gce"
    kubernetes.io/tls-acme: "false"
    ...

... and should not be picked up

@MaikuMori
Copy link

I had similar issue trying to deploy 2 NGINX Ingress Controllers with different classes. Sadly currently don't have time to reproduce and write full bug report.

@aledbf
Copy link
Member

aledbf commented Mar 9, 2017

@goddva I can reproduce this issue. Fix will be included in tomorrow release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants