Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin function name 'header' should be 'header_filter' in docs 'Custom Lua plugins' #5814

Closed
lidajia opened this issue Jun 29, 2020 · 2 comments · Fixed by #5821
Closed
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@lidajia
Copy link

lidajia commented Jun 29, 2020

NGINX Ingress controller version:
0.33
Kubernetes version (use kubectl version):
1.18
Environment:

  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:

What happened:
In docs 'Custom Lua plugins', plugin function 'header' can't run in 'header_filter_by_lua' processing phases

What you expected to happen:
ngx.get_phase return 'header_filter' not 'header' on 'header_filter_by_lua' processing phases
https://github.com/openresty/lua-nginx-module#ngxget_phase

should change function name 'header' to 'header_filter'

How to reproduce it:

Anything else we need to know:

/kind bug

@lidajia lidajia added the kind/bug Categorizes issue or PR as related to a bug. label Jun 29, 2020
@aledbf
Copy link
Member

aledbf commented Jun 29, 2020

@ElvinEfendi ping

@ElvinEfendi
Copy link
Member

oh @agile6v beat me to it :)
I'm going to close my PR

thanks for the report @lidajia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants