refactor ssl handling in preparation of OCSP stapling #5122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
Codecov Report
@@ Coverage Diff @@
## master #5122 +/- ##
==========================================
- Coverage 58.68% 58.65% -0.03%
==========================================
Files 88 88
Lines 6850 6850
==========================================
- Hits 4020 4018 -2
- Misses 2390 2391 +1
- Partials 440 441 +1
Continue to review full report at Codecov.
|
ElvinEfendi
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/test pull-ingress-nginx-e2e-1-17 |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In order to extract OCSP responder URL and generate OCSP request DER encoded version of a certificate is needed: https://github.com/openresty/lua-resty-core/blob/master/lib/ngx/ocsp.md.
UID will be used to check whether OCSP stapling should be done for the given certificate.
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Checklist: