From aede6dba0b46552ce7ae92ea75241e67faa6a990 Mon Sep 17 00:00:00 2001 From: Manuel Alejandro de Brito Fontes Date: Tue, 23 Jun 2020 16:07:48 -0400 Subject: [PATCH] Update comment about restart of pod --- internal/ingress/controller/nginx.go | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/internal/ingress/controller/nginx.go b/internal/ingress/controller/nginx.go index af1e5027dd..b384d6bb43 100644 --- a/internal/ingress/controller/nginx.go +++ b/internal/ingress/controller/nginx.go @@ -337,13 +337,9 @@ func (n *NGINXController) Start() { return } - // if the nginx master process dies the workers continue to process requests, - // passing checks but in case of updates in ingress no updates will be - // reflected in the nginx configuration which can lead to confusion and report - // issues because of this behavior. - // To avoid this issue we restart nginx in case of errors. + // if the nginx master process dies, the workers continue to process requests + // until the failure of the configured livenessProbe and restart of the pod. if process.IsRespawnIfRequired(err) { - // release command resources return }