[#4479] Add stream-snippet as a ConfigMap option

[kayrus]

What this PR does / why we need it:

This would make it possible to define extra configuration for the stream
context through the ConfigMap. An e2e test is added similar to the
existing main-snippet config option.

Additionally, this commit fills a few documentation gaps in the
development guide, found during testing the above change.

This resolves #4479

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

This resolves #4479

How Has This Been Tested?

Added an e2e test named test/e2e/settings/stream_snippet.go and ran the end to end tests following the steps described in development guide. All selected tests passed.

Ran 267 of 271 Specs in 929.406 seconds
SUCCESS! -- 267 Passed | 0 Failed | 0 Flaked | 0 Pending | 4 Skipped

This PR is still WIP since I'm doing a final round of testing with a deployment on K8s. I will remove the status once the functional test passes.

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added tests to cover my changes.
• All new and existing tests passed.

cc @chamilad

[k8s-ci-robot]

Welcome @kayrus!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @kayrus. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kayrus
To complete the pull request process, please assign bowei after the PR has been reviewed.
You can assign the PR to them by writing /assign @bowei in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[aledbf]

Closing. Please reopen when you finish your draft. Thanks

[alfredkrohmer]

@aledbf why was this closed? This looks pretty complete to me.

[iamNoah1]

/reopen

[k8s-ci-robot]

@iamNoah1: Failed to re-open PR: state cannot be changed. The master branch has been deleted.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Eun]

Hello 👋,
I will take this over and create a new PR with proper e2e tests in a bit.