Drop v1beta1 from ingress nginx

[rikatz]

Signed-off-by: Ricardo Pchevuzinske Katz ricardo.katz@gmail.com

What this PR does / why we need it:

Drop v1beta1 support from ingress NGINX

Types of changes

This is a BREAKING CHANGE! Only K8s >= v1.19 will work with ingress NGINX once this is released

Which issue/s this PR fixes

fixes #7145

How Has This Been Tested?

Need to change yet e2e tests and the controller logics to accept the new Service struct instead of ServiceName and ServicePort
Need to check if every e2e tests passes

TODO:

• Change the controller.go logic (missing part)
• Change e2e tests
• Verify if we can write the admission webhook to drop requests with v1beta1 (should we??)
• Warn users / make some blog post about the new version supporting only k8s >= 1.19
• Release betas before releasing the final version

[rikatz]

/cc @cpanato @strongjz @ElvinEfendi @aojea

[k8s-ci-robot]

@rikatz: GitHub didn't allow me to request PR reviews from the following users: strongjz.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @cpanato @strongjz @ElvinEfendi @aojea

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[aojea]

# k8s.io/ingress-nginx/internal/ingress/controller
internal/ingress/controller/controller.go:827:54: ing.Ingress.Spec.Backend undefined (type "k8s.io/api/networking/v1".IngressSpec has no field or method Backend)
internal/ingress/controller/controller.go:855:40: path.Backend.ServicePort undefined (type "k8s.io/api/networking/v1".IngressBackend has no field or method ServicePort)
internal/ingress/controller/controller.go:866:63: path.Backend.ServiceName undefined (type "k8s.io/api/networking/v1".IngressBackend has no field or method ServiceName)
internal/ingress/controller/controller.go:891:58: path.Backend.ServicePort undefined (type "k8s.io/api/networking/v1".IngressBackend has no field or method ServicePort)

[rikatz]

Yeap it's wip. There's still the controller.go to be adjusted :)

[tao12345666333]

SGTM! 👍

[rikatz]

/test pull-ingress-nginx-test

[rikatz]

For a future me:

Need to test defaultBackend and other backends with services with namedPort and numberedPorts

[cpanato]

LGTM

[strongjz]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz, strongjz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rikatz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[afrittoli]

@rikatz Since a few days the kind deployment of the ingress nginx has stopped working for me:

E0629 09:41:51.663924       8 server.go:84] "failed to process webhook request" err="rejecting admission review because the request does not contain an Ingress resource but networking.k8s.io/v1, Kind=Ingress with name tekton-dashboard in namespace tekton-pipelines"

I get this with both v1 and v1beta1 kind of ingress resources, using k8s nodes 1.20.
If I rollback the changes to the validating webhook config ValidatingWebhookConfiguration/ingress-nginx-admission things start to work again.

I also see that in the PR the k8s version has been updated to 1.21 - does this mean that 1.20 is not supported anymore?