-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Clarify default-backend behavior #7489
docs: Clarify default-backend behavior #7489
Conversation
Clarify default-backend behaviour for services with multiple ports. Also minor fixes for typos and language consistency.
@sandipb: This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @sandipb! |
Hi @sandipb. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rikatz, sandipb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Clarify default-backend behaviour for services with multiple ports. Also minor fixes for typos and language consistency.
Clarify default-backend behaviour for services with multiple ports.
Also minor fixes for typos and language consistency.
What this PR does / why we need it:
The
nginx.ingress.kubernetes.io/default-backend annotation
does not clearly mention how the port selection of service is done, especially if the service has multiple ports. This caused a lot of frustration for me recently when I was attempting to use this annotation. I hope others are not bitten by this.Types of changes
Which issue/s this PR fixes
N/A
How Has This Been Tested?
N/A
Checklist: