-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add e2e tests for canary affinity behavior feature #7529
Conversation
@wasker: This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @wasker. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rikatz FYI, replacement PR for canary affinity e2e tests. |
/ok-to-test |
@wasker error is due to update of Go to v1.17 Gonna leave this approved, you just need to run gofmt and hack/update-codegen.sh No need to rebase or squash, bot will do this Thanks! /label tide/merge-method-squash |
@rikatz Everything's done. I think only you can merge it. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rikatz, wasker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Added end-to-end tests for canary affinity behavior.
Types of changes
Which issue/s this PR fixes
Fixes #7408
How Has This Been Tested?
Ran e2e tests.
Checklist: