Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change enable-snippet to allow-snippet-annotation #7670

Merged
merged 1 commit into from
Sep 20, 2021
Merged

Change enable-snippet to allow-snippet-annotation #7670

merged 1 commit into from
Sep 20, 2021

Conversation

rikatz
Copy link
Contributor

@rikatz rikatz commented Sep 20, 2021

Signed-off-by: Ricardo Pchevuzinske Katz rkatz@vmware.com

What this PR does / why we need it:

Per @ElvinEfendi suggestion (late PR after the other one got merged)

/hold

@rikatz
Change enable-snippet to allow-snippet-annotation
b5d8fa2 
Signed-off-by: Ricardo Pchevuzinske Katz <rkatz@vmware.com>
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 20, 2021
@k8s-ci-robot
Copy link
Contributor

@rikatz: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 20, 2021
@k8s-ci-robot k8s-ci-robot added area/docs area/helm Issues or PRs related to helm charts approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 20, 2021
cpanato
cpanato approved these changes Sep 20, 2021
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2021
tao12345666333
tao12345666333 reviewed Sep 20, 2021
View reviewed changes
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElvinEfendi
Copy link
Member

ElvinEfendi commented Sep 20, 2021 •
edited
Loading

thanks for following up with the refactor!

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, ElvinEfendi, rikatz, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rikatz
Copy link
Contributor Author

rikatz commented Sep 20, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit 4fc57dc into kubernetes:main Sep 20, 2021
@rikatz rikatz mentioned this pull request Sep 20, 2021
Merged
rikatz added a commit to rikatz/ingress-nginx that referenced this pull request Sep 21, 2021
@rikatz
Change enable-snippet to allow-snippet-annotation (kubernetes#7670)
30135a2 
Signed-off-by: Ricardo Pchevuzinske Katz <rkatz@vmware.com>
k8s-ci-robot pushed a commit that referenced this pull request Sep 21, 2021
@rikatz
Change enable-snippet to allow-snippet-annotation (#7670) (#7677)
bb26584 
Signed-off-by: Ricardo Pchevuzinske Katz <rkatz@vmware.com>
@rikatz rikatz mentioned this pull request Oct 21, 2021
Closed
@brross brross mentioned this pull request Nov 5, 2021
Open
rchshld pushed a commit to joomcode/ingress-nginx that referenced this pull request May 19, 2023
@rikatz @rchshld
Change enable-snippet to allow-snippet-annotation (kubernetes#7670)
a98ed9b 
Signed-off-by: Ricardo Pchevuzinske Katz <rkatz@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@tao12345666333 tao12345666333 tao12345666333 approved these changes

Assignees

@ElvinEfendi ElvinEfendi

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/docs area/helm Issues or PRs related to helm charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rikatz @k8s-ci-robot @ElvinEfendi @tao12345666333 @cpanato