Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change sanitization message from error to warning #7963

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Change sanitization message from error to warning #7963

merged 1 commit into from
Nov 23, 2021

Conversation

rikatz
Copy link
Contributor

@rikatz rikatz commented Nov 23, 2021

Signed-off-by: Ricardo Pchevuzinske Katz ricardo.katz@gmail.com
We are issuing log errors when we should be warning on sanitization errors

@rikatz
Change sanitization message from error to warning
913e869 
Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 23, 2021
@rikatz
Copy link
Contributor Author

rikatz commented Nov 23, 2021

/hold

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 23, 2021
@strongjz
Copy link
Member

/kind feature
/priority critical-urgent
/triage accepted

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 23, 2021
@rikatz rikatz added this to the v1.1.0 milestone Nov 23, 2021
@rikatz rikatz merged commit c0814c6 into kubernetes:main Nov 23, 2021
strongjz pushed a commit to strongjz/ingress-nginx that referenced this pull request Nov 24, 2021
@rikatz @strongjz
Change sanitization message from error to warning (kubernetes#7963)
eeb15d6 
Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com>
k8s-ci-robot pushed a commit that referenced this pull request Nov 24, 2021
@strongjz @rikatz
Legacy cherrypick (#7965)
18e6eb0 
* update default block list,docs, tests (#7942)

* update default block list,docs, tests

* fix config for admin test

* gofmt

* remove the err return

* Change sanitization message from error to warning (#7963)

Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com>

* duplicate test

Co-authored-by: Ricardo Katz <rikatz@users.noreply.github.com>
rchshld pushed a commit to joomcode/ingress-nginx that referenced this pull request May 19, 2023
@rikatz @rchshld
Change sanitization message from error to warning (kubernetes#7963)
3177f8e 
Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElvinEfendi ElvinEfendi Awaiting requested review from ElvinEfendi

@strongjz strongjz Awaiting requested review from strongjz

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rikatz @k8s-ci-robot @strongjz