Add stream-snippet as a ConfigMap and Annotation option

[Eun]

What this PR does / why we need it:

This would make it possible to define extra configuration for the stream
context through the ConfigMap or an ingress annotation. e2e tests have been created for the new functionality.

This resolves the issue #4479 and replaces the pr #6404

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation only

Which issue/s this PR fixes

fixes #4479
replaces #6404

How Has This Been Tested?

added e2e tests

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added tests to cover my changes.
• All new and existing tests passed.

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ Tobias Salzmann (b83fc78469482273b8e934c24b59cf8319116f24)

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @Eun!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @Eun. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[iamNoah1]

Thanks @Eun

/triage accepted
/priority important-longterm

[iamNoah1]

/kind feature

[rikatz]

/ok-to-test

[iamNoah1]

@Eun

Please see go sec linting, that failed

[Eun]

@iamNoah1 I already checked the linter output, however this is not related to this pull request since the same errors also appear on all other commits: https://github.com/kubernetes/ingress-nginx/commits/main

Please advice how I should proceed.

[iamNoah1]

@Eun good point. @rikatz how should we proceed here?

[rikatz]

/assign IamNoah1

[Eun]

(I rebased, this fixed the security issue)

[rikatz]

This can be used for good, and for evil :)

I'm really worried nowadays about allowing more snippets directives, will need to think a bit better on this.

[rikatz]

Spoke with @strongjz and we can merge this. We need tho to keep a good eye on this snippet directives, as they have been our main CVE cases :)

As soon as we can ship some privilege separation between control and dataplane I will be more comfortable with this.

/approve
/lgtm
Thanks!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Eun, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rikatz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Preetham777]

Does this commit clearly handle all the stream directives?
Also is there a support or plan for this : https://docs.nginx.com/nginx/admin-guide/security-controls/terminating-ssl-tcp/#complete-example

[Eun]

Well this pr just adds the capability to use the stream snippet, the functionality is dependent on the nginx build.
Since the nginx binary in ingress-nginx is currently built with --with-stream_ssl_module, ssl termination should be available.