From 844ea6a86408dd2efdc38cb51cf0fa7392d4fbe1 Mon Sep 17 00:00:00 2001 From: Manuel de Brito Fontes Date: Tue, 27 Jun 2017 20:18:08 -0400 Subject: [PATCH] Add arm and ppc64le support --- controllers/nginx/Makefile | 98 +++++++++++++++++++++++++---- controllers/nginx/rootfs/Dockerfile | 11 ++-- 2 files changed, 92 insertions(+), 17 deletions(-) diff --git a/controllers/nginx/Makefile b/controllers/nginx/Makefile index b1ff792ef9..2250d497b9 100644 --- a/controllers/nginx/Makefile +++ b/controllers/nginx/Makefile @@ -3,8 +3,8 @@ all: push BUILDTAGS= # Use the 0.0 tag for testing, it shouldn't clobber any release builds -RELEASE?=0.9.0-beta.8 -PREFIX?=gcr.io/google_containers/nginx-ingress-controller +TAG?=0.9.0-beta.8 +REGISTRY?=gcr.io/google_containers GOOS?=linux DOCKER?=gcloud docker -- @@ -16,16 +16,91 @@ endif PKG=k8s.io/ingress/controllers/nginx -build: clean - CGO_ENABLED=0 GOOS=${GOOS} go build -a -installsuffix cgo \ - -ldflags "-s -w -X ${PKG}/pkg/version.RELEASE=${RELEASE} -X ${PKG}/pkg/version.COMMIT=${COMMIT} -X ${PKG}/pkg/version.REPO=${REPO_INFO}" \ - -o rootfs/nginx-ingress-controller ${PKG}/pkg/cmd/controller +ARCH ?= $(shell go env GOARCH) +GOARCH = ${ARCH} +DUMB_ARCH = ${ARCH} + +ALL_ARCH = amd64 arm ppc64le + +QEMUVERSION=v2.7.0 + +IMGNAME = nginx-ingress-controller +IMAGE = $(REGISTRY)/$(IMGNAME) +MULTI_ARCH_IMG = $(IMAGE)-$(ARCH) + +# Set default base image dynamically for each arch +BASEIMAGE?=gcr.io/google_containers/nginx-slim-$(ARCH):0.20 + +ifeq ($(ARCH),arm) + QEMUARCH=arm + GOARCH=arm + DUMB_ARCH=armhf +endif +#ifeq ($(ARCH),arm64) +# QEMUARCH=aarch64 +#endif +ifeq ($(ARCH),ppc64le) + QEMUARCH=ppc64le + GOARCH=ppc64le + DUMB_ARCH=ppc64el +endif +#ifeq ($(ARCH),s390x) +# QEMUARCH=s390x +#endif + +TEMP_DIR := $(shell mktemp -d) + +all: all-container + +sub-container-%: + $(MAKE) ARCH=$* build container + +sub-push-%: + $(MAKE) ARCH=$* push -container: build - $(DOCKER) build --pull -t $(PREFIX):$(RELEASE) rootfs +all-container: $(addprefix sub-container-,$(ALL_ARCH)) -push: container - $(DOCKER) push $(PREFIX):$(RELEASE) +all-push: $(addprefix sub-push-,$(ALL_ARCH)) + +container: .container-$(ARCH) +.container-$(ARCH): + cp -r ./* $(TEMP_DIR) + cd $(TEMP_DIR) && sed -i 's|BASEIMAGE|$(BASEIMAGE)|g' rootfs/Dockerfile + cd $(TEMP_DIR) && sed -i "s|QEMUARCH|$(QEMUARCH)|g" rootfs/Dockerfile + cd $(TEMP_DIR) && sed -i "s|DUMB_ARCH|$(DUMB_ARCH)|g" rootfs/Dockerfile + +ifeq ($(ARCH),amd64) + # When building "normally" for amd64, remove the whole line, it has no part in the amd64 image + cd $(TEMP_DIR) && sed -i "/CROSS_BUILD_/d" rootfs/Dockerfile +else + # When cross-building, only the placeholder "CROSS_BUILD_" should be removed + # Register /usr/bin/qemu-ARCH-static as the handler for ARM binaries in the kernel + $(DOCKER) run --rm --privileged multiarch/qemu-user-static:register --reset + curl -sSL https://github.com/multiarch/qemu-user-static/releases/download/$(QEMUVERSION)/x86_64_qemu-$(QEMUARCH)-static.tar.gz | tar -xz -C $(TEMP_DIR)/rootfs + cd $(TEMP_DIR) && sed -i "s/CROSS_BUILD_//g" rootfs/Dockerfile +endif + + $(DOCKER) build -t $(MULTI_ARCH_IMG):$(TAG) $(TEMP_DIR)/rootfs + +ifeq ($(ARCH), amd64) + # This is for to maintain the backward compatibility + $(DOCKER) tag $(MULTI_ARCH_IMG):$(TAG) $(IMAGE):$(TAG) +endif + +push: .push-$(ARCH) +.push-$(ARCH): .container-$(ARCH) + $(DOCKER) push $(MULTI_ARCH_IMG):$(TAG) +ifeq ($(ARCH), amd64) + $(DOCKER) push $(IMAGE):$(TAG) +endif + +clean: + $(DOCKER) rmi -f $(MULTI_ARCH_IMG):$(TAG) || true + +build: clean + CGO_ENABLED=0 GOOS=${GOOS} GOARCH=${GOARCH} go build -a -installsuffix cgo \ + -ldflags "-s -w -X ${PKG}/pkg/version.RELEASE=${TAG} -X ${PKG}/pkg/version.COMMIT=${COMMIT} -X ${PKG}/pkg/version.REPO=${REPO_INFO}" \ + -o $(TEMP_DIR)/rootfs/nginx-ingress-controller ${PKG}/pkg/cmd/controller fmt: @echo "+ $@" @@ -48,6 +123,3 @@ cover: vet: @echo "+ $@" @go vet $(shell go list ${PKG}/... | grep -v vendor) - -clean: - rm -f rootfs/nginx-ingress-controller diff --git a/controllers/nginx/rootfs/Dockerfile b/controllers/nginx/rootfs/Dockerfile index a9ff6c5450..72565d8a66 100644 --- a/controllers/nginx/rootfs/Dockerfile +++ b/controllers/nginx/rootfs/Dockerfile @@ -12,17 +12,20 @@ # See the License for the specific language governing permissions and # limitations under the License. -FROM gcr.io/google_containers/nginx-slim-amd64:0.19 +FROM BASEIMAGE + +CROSS_BUILD_COPY qemu-QEMUARCH-static /usr/bin/ RUN DEBIAN_FRONTEND=noninteractive apt-get update && apt-get install -y \ diffutils \ --no-install-recommends \ && rm -rf /var/lib/apt/lists/* -RUN curl -sSL -o /sbin/tini https://github.com/krallin/tini/releases/download/v0.14.0/tini-amd64 && \ - chmod +x /sbin/tini +RUN curl -sSL -o /tmp/dumb-init.deb http://ftp.us.debian.org/debian/pool/main/d/dumb-init/dumb-init_1.2.0-1_DUMB_ARCH.deb && \ + dpkg -i /tmp/dumb-init.deb && \ + rm /tmp/dumb-init.deb -ENTRYPOINT ["/sbin/tini", "--"] +ENTRYPOINT ["/usr/bin/dumb-init", "-v"] COPY . /