-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add annotation to allow to add custom response headers #9742
Conversation
52c48a3
to
7354ab4
Compare
Hi @cgroschupp. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
7354ab4
to
668507c
Compare
@cgroschupp This PR looks good so far, can you add an e2e test as well Here is the annotations e2e https://github.com/kubernetes/ingress-nginx/tree/main/test/e2e/annotations |
/triage accepted |
d9d53e5
to
4eb6fb0
Compare
@strongjz i added the e2e tests. |
This reverts commit ab48392b60dee4ce146a4c17e046849f9633c7fb.
564bafb
to
0d2ea1a
Compare
@pierluigilenoci I rebased the code agian and it is now green. |
@tao12345666333 The LGTM label is missing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgroschupp, pierluigilenoci, tao12345666333 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
This PR has been discussed in our community meeting and slack. It is only because of the delay in our review that it has been merged now. So sorry 😞 |
Thank you @cgroschupp!!! |
What this PR does / why we need it:
Because of the CVE-2021-25742, we need a better way to define response headers, when snippets are disabled.
Types of changes
Which issue/s this PR fixes
fixes #7811
How Has This Been Tested?
Checklist:
Does my pull request need a release note?
Any user-visible or operator-visible change qualifies for a release note. This could be a:
No release notes are required for changes to the following:
For more tips on writing good release notes, check out the Release Notes Handbook