Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The fields of vtsDate are unified in the form of plural #1013

Merged
merged 1 commit into from
Jul 27, 2017
Merged

The fields of vtsDate are unified in the form of plural #1013

merged 1 commit into from
Jul 27, 2017

Conversation

caiyixiang
Copy link
Contributor

Since some of the fields in the vstDate are in the plural format, but some are singular, I think it's better to unify them into the plural

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 25, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 43.912% when pulling 2b72441 on caiyixiang:unify_forms into a58b800 on kubernetes:master.

@aledbf aledbf self-assigned this Jul 27, 2017
@aledbf
Copy link
Member

aledbf commented Jul 27, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2017
@aledbf
Copy link
Member

aledbf commented Jul 27, 2017

@caiyixiang thanks!

@aledbf aledbf merged commit a56dd7c into kubernetes:master Jul 27, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@caiyixiang @k8s-reviewable @coveralls @aledbf @k8s-ci-robot