Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove lua and use fastcgi to render errors #1074

Merged
merged 2 commits into from
Aug 8, 2017
Merged

Remove lua and use fastcgi to render errors #1074

merged 2 commits into from
Aug 8, 2017

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Aug 4, 2017

This change removes lua as dependency of the ingress controller and also allows adding arm64 platform

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 4, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 43.782% when pulling cb16bf9 on aledbf:rem-lua into faf80ad on kubernetes:master.

@aledbf aledbf force-pushed the rem-lua branch 2 times, most recently from 4223fd2 to db93664 Compare August 4, 2017 20:16
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 43.743% when pulling db93664 on aledbf:rem-lua into faf80ad on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 43.739% when pulling db93664 on aledbf:rem-lua into faf80ad on kubernetes:master.

@aledbf aledbf changed the title WIP: Remove lua and use fastcgi to render errors Remove lua and use fastcgi to render errors Aug 5, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 43.752% when pulling 69e766e on aledbf:rem-lua into 0fad23a on kubernetes:master.

@aledbf aledbf merged commit cf732e8 into kubernetes:master Aug 8, 2017
@aledbf aledbf deleted the rem-lua branch August 8, 2017 15:38
aledbf added a commit to aledbf/ingress-nginx that referenced this pull request Aug 15, 2017
@aledbf
Fix status update - changed in kubernetes#1074
a2217ab
aledbf added a commit that referenced this pull request Aug 15, 2017
@aledbf
Merge pull request #1136 from aledbf/revert-status
81a36b4 
Fix status update - changed in #1074
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aledbf @k8s-reviewable @coveralls @k8s-ci-robot