Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat/ #374) support proxy timeout #1075

Merged
merged 1 commit into from
Aug 7, 2017

Conversation

zjj2wry
Copy link

@zjj2wry zjj2wry commented Aug 5, 2017

#374
add ingress.kubernetes.io/proxyTimeout annotation in L4-configmap. default alse 600s.

apiVersion: v1
data:
  "99": caicloud-io/serving-manager:8080
kind: ConfigMap
metadata:
  annotations:
    ingress.kubernetes.io/proxyTimeout: 1h
  name: proxy-nginx-tcp
  namespace: kube-system

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 5, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 43.965% when pulling 5179323e3bfcd399d6cf88f1486b4ccb7d6cfd87 on zjj2wry:feat/proxy_timeout into faf80ad on kubernetes:master.

@aledbf
Copy link
Member

aledbf commented Aug 5, 2017

@zjj2wry please use the existing approach to parse annotations https://github.com/kubernetes/ingress/tree/master/core/pkg/ingress/annotations

@aledbf
Copy link
Member

aledbf commented Aug 5, 2017

Also change the name to something like proxy-stream-timeout

@zjj2wry zjj2wry changed the title (feat/proxy_timeout) support proxy timeout (feat/ #374) support proxy timeout Aug 7, 2017
@zjj2wry
Copy link
Author

zjj2wry commented Aug 7, 2017

@aledbf now set this config in global. and must restart can be reload.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 44.993% when pulling 13ab894 on zjj2wry:feat/proxy_timeout into 413b4ad on kubernetes:master.

@aledbf aledbf self-assigned this Aug 7, 2017
@aledbf
Copy link
Member

aledbf commented Aug 7, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2017
@aledbf aledbf merged commit a3ca02e into kubernetes:master Aug 7, 2017
@aledbf
Copy link
Member

aledbf commented Aug 7, 2017

@zjj2wry thanks!

@AEGEGE
Copy link

AEGEGE commented Aug 28, 2019

apiVersion: v1
data:
  "2222": kube-ops/jumpserver:2222
kind: ConfigMap
metadata:
  annotations:
    ingress.kubernetes.io/proxyTimeout: 1800s
  labels:
    app: nginx-ingress
    chart: nginx-ingress-1.17.0
    component: controller
    heritage: Tiller
    release: nginx-ingress
  name: nginx-ingress-tcp
  namespace: kube-ops

I set it up like this and restarted all the pods, and found that it hasn't changed. It's still the default 600s.

@AEGEGE
Copy link

AEGEGE commented Aug 28, 2019

#374
add ingress.kubernetes.io/proxyTimeout annotation in L4-configmap. default alse 600s.

apiVersion: v1
data:
  "99": caicloud-io/serving-manager:8080
kind: ConfigMap
metadata:
  annotations:
    ingress.kubernetes.io/proxyTimeout: 1h
  name: proxy-nginx-tcp
  namespace: kube-system

apiVersion: v1
data:
"2222": kube-ops/jumpserver:2222
kind: ConfigMap
metadata:
annotations:
ingress.kubernetes.io/proxyTimeout: 1800s
labels:
app: nginx-ingress
chart: nginx-ingress-1.17.0
component: controller
heritage: Tiller
release: nginx-ingress
name: nginx-ingress-tcp
namespace: kube-ops

I set it up like this and restarted all the pods, and found that it hasn't changed. It's still the default 600s.

@whalecold
Copy link
Contributor

#374
add ingress.kubernetes.io/proxyTimeout annotation in L4-configmap. default alse 600s.

apiVersion: v1
data:
  "99": caicloud-io/serving-manager:8080
kind: ConfigMap
metadata:
  annotations:
    ingress.kubernetes.io/proxyTimeout: 1h
  name: proxy-nginx-tcp
  namespace: kube-system

apiVersion: v1
data:
"2222": kube-ops/jumpserver:2222
kind: ConfigMap
metadata:
annotations:
ingress.kubernetes.io/proxyTimeout: 1800s
labels:
app: nginx-ingress
chart: nginx-ingress-1.17.0
component: controller
heritage: Tiller
release: nginx-ingress
name: nginx-ingress-tcp
namespace: kube-ops

I set it up like this and restarted all the pods, and found that it hasn't changed. It's still the default 600s.

try use ingress.kubernetes.io/proxy-stream-timeout.

@taybur43
Copy link

Is it solved?
annotations:
ingress.kubernetes.io/proxyTimeout: 1h in tcp service config map but it's still the default 600s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants