Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefect unit test cases for annotation.proxy #158

Merged
merged 1 commit into from
Jan 23, 2017

Conversation

chentao1596
Copy link

  1. prefect unit test cases for annotation.proxy;
  2. for the line 91 & 95, i think "Fatalf" will be better than "Errorf", because if error occurs, the next process will no need to execute.
    thank you!

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 23, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 43.213% when pulling a8d235c8139b9611d17f4435ea74b4891b5be079 on chentao1596:proxy-main-test into 527159e on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 43.152% when pulling 5990359 on chentao1596:proxy-main-test into 527159e on kubernetes:master.

@aledbf aledbf self-assigned this Jan 23, 2017
@aledbf
Copy link
Member

aledbf commented Jan 23, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2017
@aledbf
Copy link
Member

aledbf commented Jan 23, 2017

@chentao1596 thanks!

@aledbf aledbf merged commit 3927ed8 into kubernetes:master Jan 23, 2017
@chentao1596 chentao1596 deleted the proxy-main-test branch January 24, 2017 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants