Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add some unit test cases for some packages under folder "core.pkg.ingress" #172

Merged
merged 3 commits into from
Jan 25, 2017
Merged

add some unit test cases for some packages under folder "core.pkg.ingress" #172

merged 3 commits into from
Jan 25, 2017

Conversation

chentao1596
Copy link

Add some unit test cases, thank you!

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 25, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage increased (+1.3%) to 44.514% when pulling 93c7128 on chentao1596:prefect-util-test into 40406b1 on kubernetes:master.

@aledbf aledbf self-assigned this Jan 25, 2017
@aledbf
Copy link
Member

aledbf commented Jan 25, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2017
@aledbf
Copy link
Member

aledbf commented Jan 25, 2017

@chentao1596 thanks!

@aledbf aledbf merged commit 800d680 into kubernetes:master Jan 25, 2017
@chentao1596 chentao1596 deleted the prefect-util-test branch February 10, 2017 09:10
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chentao1596 @k8s-reviewable @coveralls @aledbf @k8s-ci-robot @chentao11596