Match named port between container and probe #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were previous matching the target port with the readiness probe, and hence dropping the case where the container port and the probe had the same name, but the target port did not.
k8s-ci-robot
added
cncf-cla: yes
|
This change is |
thockin
approved these changes
Jan 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some confusion around both the targetPort and the readinessProbe
port being IntOrString, but the container port having both a numeric value
and name. More specifically, we were previous matching the target port
with the readiness probe, and hence dropping the case where the container
port and the probe had the same name, but the target port did not.