Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vet complains about "StoreToIngressLister composite literal uses unkeyed fields" #335

Closed
porridge opened this issue Feb 24, 2017 · 4 comments

Comments

@porridge
Copy link
Member

simple make fails like this:

$ make
/home/porridge/Desktop/coding/go/src/k8s.io/ingress/controllers/nginx/pkg/template/template.go
core/pkg/ingress/status/status_test.go:216: k8s.io/ingress/core/pkg/cache.StoreToIngressLister composite literal uses unkeyed fields
exit status 1
make: *** [vet] Error 1
@porridge
Copy link
Member Author

I wonder why the checks which run on PRs did not prevent this from happening?
Is my toolchain too different? go version go1.7.3 linux/amd64

porridge added a commit to porridge/ingress that referenced this issue Feb 24, 2017
aledbf added a commit that referenced this issue Feb 24, 2017
@aledbf
Copy link
Member

aledbf commented Feb 24, 2017

@porridge because the link task in the makefile is using -min_confidence=0.85 because some code in the gce controller

@aledbf
Copy link
Member

aledbf commented Feb 25, 2017

@porridge please reopen if you still have issues

@aledbf aledbf closed this as completed Feb 25, 2017
@porridge
Copy link
Member Author

@aledbf hm, but what does lint have to do with vet? Seems to be a separate task in the Makefile.
I'm assuming you meant lint, not link there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants