Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test case for named_port #490

Merged
merged 2 commits into from
Mar 24, 2017
Merged

Add unit test case for named_port #490

merged 2 commits into from
Mar 24, 2017

Conversation

chentao1596
Copy link 

Just what like the descriptions of two commits, thank you!

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 24, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 43.763% when pulling 740f7ca on chentao1596:name_port_unittest into 116fbe8 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 43.796% when pulling 740f7ca on chentao1596:name_port_unittest into 116fbe8 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 43.796% when pulling 740f7ca on chentao1596:name_port_unittest into 116fbe8 on kubernetes:master.

@aledbf aledbf self-assigned this Mar 24, 2017
@aledbf
Copy link
Member

aledbf commented Mar 24, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2017
@aledbf
Copy link
Member

aledbf commented Mar 24, 2017

@chentao1596 thanks!

@aledbf aledbf merged commit e8b61b4 into kubernetes:master Mar 24, 2017
@chentao1596 chentao1596 deleted the name_port_unittest branch March 27, 2017 01:05
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chentao1596 @k8s-reviewable @coveralls @aledbf @k8s-ci-robot @chentao11596