Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TLS secret configuration #500

Merged
merged 1 commit into from
Mar 26, 2017

Conversation

jcmoraisjr
Copy link
Contributor

This PR implements the following behavior on ingress.spec.tls[]


foo.bar uses existentSecret and bar.baz uses default TLS secret:

  rules:
  - host: foo.bar
    ...
  - host: bar.baz
    ...
  tls:
  - hosts:
    - foo.bar
    secretName: existentSecret
  - hosts:
    - bar.baz

foo.bar uses default TLS secret and bar.baz doesn't configure TLS/https:

  rules:
  - host: foo.bar
    ...
  - host: bar.baz
    ...
  tls:
  - hosts:
    - foo.bar

foo.bar uses default TLS secret, bar.baz doesn't configure TLS/https and log warn about secret not found:

  rules:
  - host: foo.bar
    ...
  - host: bar.baz
    ...
  tls:
  - hosts:
    - foo.bar
  - hosts:
    - bar.baz
    secretName: nonexistentSecret

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 26, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 43.732% when pulling 567041e on jcmoraisjr:jm-improve-tls-secret into f521145 on kubernetes:master.

@aledbf aledbf self-assigned this Mar 26, 2017
@aledbf
Copy link
Member

aledbf commented Mar 26, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2017
@aledbf
Copy link
Member

aledbf commented Mar 26, 2017

@jcmoraisjr thanks!

@aledbf aledbf merged commit a355c5a into kubernetes:master Mar 26, 2017
@jcmoraisjr jcmoraisjr deleted the jm-improve-tls-secret branch March 26, 2017 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants