Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid port in upstream #57

Closed
wants to merge 1 commit into from

Conversation

gianrubio
Copy link
Contributor

If you don't have the ingress port mapped same as the service, you got the error "invalid port in upstream" on nginx. To fix this, we should check if the targetPort is valid (>0).
Fix #53

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.


If you have questions or suggestions related to this bot's behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 14, 2016
@k8s-reviewable
Copy link

This change is Reviewable

@gianrubio gianrubio closed this Dec 14, 2016
@gianrubio gianrubio deleted the branch/invalid-port branch December 14, 2016 16:25
@gianrubio gianrubio restored the branch/invalid-port branch December 14, 2016 16:25
@gianrubio gianrubio reopened this Dec 14, 2016
@gianrubio
Copy link
Contributor Author

I signed it!

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 39.753% when pulling f0738f7 on gianrubio:branch/invalid-port into 0af8ccc on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 39.753% when pulling f0738f7 on gianrubio:branch/invalid-port into 0af8ccc on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 39.753% when pulling f0738f7 on gianrubio:branch/invalid-port into 0af8ccc on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 39.753% when pulling f0738f7 on gianrubio:branch/invalid-port into 0af8ccc on kubernetes:master.

hnrytrn pushed a commit to hnrytrn/ingress-nginx that referenced this pull request Jun 20, 2018
haoqing0110 referenced this pull request in stolostron/management-ingress Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid port in upstream
4 participants