-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix invalid port in upstream #57
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA. Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.
If you have questions or suggestions related to this bot's behavior, please file an issue against the kubernetes/test-infra repository. |
I signed it! |
6292f3b
to
d294f1d
Compare
d294f1d
to
f0738f7
Compare
remove redundant logging
If you don't have the ingress port mapped same as the service, you got the error "invalid port in upstream" on nginx. To fix this, we should check if the targetPort is valid (>0).
Fix #53