Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update golang dependencies #741

Merged
merged 2 commits into from
May 22, 2017
Merged

Update golang dependencies #741

merged 2 commits into from
May 22, 2017

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented May 21, 2017

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 21, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@aledbf aledbf changed the title Update golang dependencies WIP: Update golang dependencies May 21, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 47.094% when pulling b1d6468 on aledbf:update-godeops into c5e3097 on kubernetes:master.

@nicksardo
Copy link
Contributor

@aledbf, is this ready for merge?

Out of curiosity, what do you need from the new version?

@aledbf
Copy link
Member Author

aledbf commented May 22, 2017

@nicksardo with the update of client-go I don't see resource version warnings in the informers (in 1.6.x cluster)

@aledbf
Copy link
Member Author

aledbf commented May 22, 2017

@nicksardo yes, this is ready to be merged. Just waiting your review :)

@nicksardo nicksardo changed the title WIP: Update golang dependencies Update golang dependencies May 22, 2017
@nicksardo nicksardo merged commit db06061 into kubernetes:master May 22, 2017
@aledbf
Copy link
Member Author

aledbf commented May 22, 2017

@nicksardo thanks!

jcmoraisjr
jcmoraisjr reviewed May 24, 2017
View reviewed changes
Godeps/Godeps.json
"Comment": "v1.7.0-alpha.0-1863-g289ef62",
"Rev": "289ef62442b2e74e533e2b0f1e309c70750d7423"
"Comment": "v1.7.0-alpha.4-155-g97c2b70fe3",
"Rev": "97c2b70fe316d1368169c193e72f201f0cc33d47"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't find this commit hash from Kubernetes repo.

@jcmoraisjr
Copy link
Contributor

Is this an expected message on a 1.5.x cluster?

E0524 01:31:54.311093 5 event.go:260] Could not construct reference to: '&v1beta1.Ingress{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}...the-whole-ingress-object-here...}' due to: 'no kind is registered for the type v1beta1.Ingress'. Will not report event: 'Normal' 'CREATE' 'Ingress default/app2'

Same with a v1.Endpoint.

BTW things are apparently working.

@aledbf
Copy link
Member Author

aledbf commented May 24, 2017

@jcmoraisjr yes, I am changing the event reporter

@aledbf aledbf deleted the update-godeops branch May 25, 2017 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcmoraisjr jcmoraisjr jcmoraisjr left review comments

Assignees

@nicksardo nicksardo

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aledbf @k8s-reviewable @coveralls @nicksardo @jcmoraisjr @k8s-ci-robot