Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish echoheader image #785

Merged
merged 1 commit into from
May 30, 2017
Merged

Publish echoheader image #785

merged 1 commit into from
May 30, 2017

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented May 28, 2017

This PR updates the echoheaders image to 1.5 adding information about the POD (if the env section is configured) and improves the output

$ kubectl exec echoheaders-cgrxv curl localhost:8080

Hostname: echoheaders-cgrxv

Pod Information:
	node name:	 minikube
	pod name:	 echoheaders-cgrxv
	pod namespace:	 default
	pod IP:  	 172.17.0.8

Server values:
	server_version=nginx: 1.13.0 - lua: 10008

Request Information:
	client_address=127.0.0.1
	method=GET
	real path=/
	query=
	request_version=1.1
	request_uri=http://localhost:8080/

Request Headers:
	accept=*/*
	host=localhost:8080
	user-agent=curl/7.47.0

Request Body:
	-no body in request-

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 28, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@aledbf
Copy link
Member Author

aledbf commented May 28, 2017

@nicksardo this image was removed in the migration from contrib.

Please review and if is ok, please merge and publish the image.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ade2f49 on aledbf:echoheaders into ** on kubernetes:master**.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 46.589% when pulling ade2f49 on aledbf:echoheaders into 3a9e3fd on kubernetes:master.

app: echoheaders
---
apiVersion: v1
kind: ReplicationController
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change this to a Deployment?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -0,0 +1,18 @@
# Copyright 2015 The Kubernetes Authors. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you bump this to 2017, please?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@nicksardo nicksardo merged commit a6bba68 into kubernetes:master May 30, 2017
@aledbf
Copy link
Member Author

aledbf commented May 30, 2017

@nicksardo thanks!

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 46.465% when pulling c18c8f7 on aledbf:echoheaders into 3f0307a on kubernetes:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants