-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish echoheader image #785
Conversation
@nicksardo this image was removed in the migration from contrib. Please review and if is ok, please merge and publish the image. |
Changes Unknown when pulling ade2f49 on aledbf:echoheaders into ** on kubernetes:master**. |
images/echoheaders/echo-app.yaml
Outdated
app: echoheaders | ||
--- | ||
apiVersion: v1 | ||
kind: ReplicationController |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we change this to a Deployment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
images/echoheaders/Dockerfile
Outdated
@@ -0,0 +1,18 @@ | |||
# Copyright 2015 The Kubernetes Authors. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you bump this to 2017, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@nicksardo thanks! |
This PR updates the echoheaders image to 1.5 adding information about the POD (if the env section is configured) and improves the output