Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upstream keepalive connections cache #892

Merged
merged 1 commit into from
Jun 22, 2017
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jun 22, 2017

fixes #838

@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 22, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 44.551% when pulling 6e22035 on aledbf:keepalive into 4235166 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 44.523% when pulling 6e22035 on aledbf:keepalive into 4235166 on kubernetes:master.

@aledbf aledbf merged commit 955897a into kubernetes:master Jun 22, 2017
@aledbf aledbf deleted the keepalive branch June 22, 2017 16:43
@xcompass
Copy link

In case someone run into the same problem as mine: I have a spring boot application, when the keepalive is enabled, the application respond to a few requests then stopped to respond. If I set keepalive to 1, the application stops responding for every other request. Had to remove keepalive option. No problem with other apps.

@necevil
Copy link

necevil commented Jul 16, 2018

@xcompass I think I may be running into a similar issue, how did you remove the keep alive option for the upstream service?

@xcompass
Copy link

@necevil I don't have that app anymore, so I can't check. But if I remember correctly, I had to remove the keepalive option from Nginx config (disabled by default according to this PR). You can check your nginx config to see if there is an keepalive option enabled. Hope it helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. nginx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Add ingress annotation to enable upstream "keepalive" option
6 participants